Skip to content

Update FullSend workflow pins - #594

Merged
st3penta merged 1 commit into
conforma:mainfrom
st3penta:fix/fullsend-app-set-forwarding
Oct 22, 2026
Merged

st3penta merged 1 commit into
conforma:mainfrom
st3penta:fix/fullsend-app-set-forwarding

Conversation

@st3penta

Copy link
Copy Markdown
Contributor

Update both FullSend reusable workflow pins to
0b21529c6768d9b5ec47b16994a08db83b1d406a. The pinned dispatcher
does not pass FULLSEND_APP_SET to the review runner. The current
review harness is on an older revision, but this prepares the runner
for the newer harness mapping.

Co-Authored-By: gpt-6-luna noreply@openai.com

Update both FullSend reusable workflow pins to
`0b21529c6768d9b5ec47b16994a08db83b1d406a`. The pinned dispatcher
does not pass `FULLSEND_APP_SET` to the review runner. The current
review harness is on an older revision, but this prepares the runner
for the newer harness mapping.

Co-Authored-By: gpt-6-luna <noreply@openai.com>
@st3penta
st3penta requested a review from a team as a code owner October 21, 2026 14:42
@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Oct 21, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Updating externally-pinned CI workflow SHAs in protected .github/ paths carries inherent supply-chain and security-sensitive signal, but the small diff size, consistent history of prior pin bumps, and known non-bot author keep the composite risk moderate.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] .github/workflows/fullsend.yaml, .github/workflows/prioritize.yml — Both files are under .github/, which is a governance/infrastructure path that requires explicit human approval. The PR has no linked issue, so this change cannot be traced to tracked authorization. The PR body explains that the pin bump prepares the runner for a newer harness mapping, but a prose rationale alone does not substitute for an authorizing issue reference.
    Remediation: A human reviewer must verify and approve this change. Consider linking a tracking issue (e.g., for the FullSend harness/FULLSEND_APP_SET migration) to establish traceable authorization for subsequent pin bumps on these workflows.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 3772f21c-3548-41d7-9ccb-eef6b0b0dd24
📥 Commits

Reviewing files that changed from the base of the PR and between 805ecb9 and 46a4c41.

📒 Files selected for processing: 2
  • .github/workflows/fullsend.yaml
  • .github/workflows/prioritize.yml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Both GitHub Actions workflows now reference reusable workflows pinned to commit 0b21529c6768d9b5ec47b16994a08db83b1d406a.

Changes: Reusable workflow pin updates

Layer / File(s) Summary
Update reusable workflow pins
.github/workflows/fullsend.yaml, .github/workflows/prioritize.yml
Both workflows now reference commit 0b21529c6768d9b5ec47b16994a08db83b1d406a instead of ea66a0a1e5ecb0a08780042a6b283d104fcd02e3.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: robnester-rh, acepresso

Merge Risk: ⚪ Minimal · up to 46a4c

The reusable workflow pin updates introduce no established merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly describes the main change: updating the FullSend workflow pins.
Description check Passed The description accurately explains that both reusable workflow pins changed and states the reason for the update.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@robnester-rh robnester-rh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st3penta
st3penta merged commit ba2624d into conforma:main Oct 22, 2026
69 checks passed
@st3penta
st3penta deleted the fix/fullsend-app-set-forwarding branch October 22, 2026 08:53
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #594 — Update FullSend workflow pins

Workflow went well. This was a minimal 2-line pin-bump PR by st3penta updating both FullSend reusable workflow SHAs from ea66a0a... to 0b21529... to prepare for FULLSEND_APP_SET forwarding. The review agent ran in ~10 minutes, posted a moderate risk assessment (2/5) and one high finding about the .github/ protected path needing human approval. Three humans approved (robnester-rh, cuipinghuo, simonbaird), and the PR merged ~18 hours after creation with zero rework.

The review agent's single finding was procedurally correct — .github/ paths are governance-sensitive — but provided limited actionable value beyond what humans were already going to do (review and approve). No substantive issues were missed by the review agent; coderabbitai also found nothing actionable.

Judge scores

# Score Candidate Disposition
1 2/5 Reduce governance-finding severity on human-authored PRs summary-only (duplicate of fullsend-ai/fullsend#7867)
2 3/5 Review agent should verify SHA legitimacy on pin-bump PRs summary-only (duplicate of fullsend-ai/fullsend#2624)
3 2/5 Skip review dispatch for fullsend version bump PRs summary-only (duplicate of fullsend-ai/fullsend#7357)
4 1/5 Redundant workflow triggers (8 of 10 runs skipped all agents) summary-only (low impact — normal platform routing behavior)
5 2/5 Reconsider review severity threshold summary-only (duplicate of conforma/conforma.github.io#583)
6 0/5 Bot review DISMISSED state summary-only (expected behavior when humans approve)

Evidence for existing issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants