Repository navigation
Conversation
A custom filter column rejected a whole query with "Plain words aren't supported" when one part of it was a filter for something else, such as group:, which only exists for members. The message now names the parts no discussion filter takes, so a member can see what to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Discuss: https://discuss.flarum.org/d/40038-introducing-deck-follow-every-conversation-you-care-about-live/4 (no issue)
Changes proposed in this pull request:
When a custom filter column's query has a part that isn't a discussion filter, Deck said "Use filters only, such as tag:support is:unread. Plain words aren't supported.", which led a member to think combined filters weren't supported (they are; the part it refused was
group:, then a users-only filter). It now names the parts it can't use, e.g. "group:mods isn't a filter for discussions. Use filters such as tag:support or is:unread.", in both the Add column form and the Filters window, and the message clears once the query is edited.For extensions, a column field's
invalidTextcan now be a function of what was typed.Reviewers should focus on:
app.search.gambits.match), so extensions' filters count as known.Screenshot
Necessity
Confirmed
yarn testinjs/).composer test).Required changes: