From b4a900b0f35befcc77bdad5f1344c093ca6740df Mon Sep 17 00:00:00 2001 From: Aseem Khandekar <69676297+okarin1511@users.noreply.github.com> Date: Fri, 16 Oct 2026 22:40:41 +0530 Subject: [PATCH] fix: correct error messages in NewRelic, Dynatrace, and Stackdriver providers NewRelic and Dynatrace providers wrap a nil error with %w on non-200 responses. At that point err is nil (from the successful io.ReadAll call), producing messages like "error response: : ". Changed to format the HTTP status instead. Stackdriver provider builds a detailed gRPC error string with status details but then formats the original error instead of the constructed string. Changed to use errStr in the gRPC status branch. Signed-off-by: Aseem Khandekar <69676297+okarin1511@users.noreply.github.com> --- pkg/metrics/providers/dynatrace.go | 2 +- pkg/metrics/providers/newrelic.go | 2 +- pkg/metrics/providers/stackdriver.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/metrics/providers/dynatrace.go b/pkg/metrics/providers/dynatrace.go index 7cdf5efde..aca2aaf2f 100644 --- a/pkg/metrics/providers/dynatrace.go +++ b/pkg/metrics/providers/dynatrace.go @@ -124,7 +124,7 @@ func (p *DynatraceProvider) RunQuery(query string) (float64, error) { } if r.StatusCode != http.StatusOK { - return 0, fmt.Errorf("error response: %s: %w", string(b), err) + return 0, fmt.Errorf("error response: %s: %s", string(b), r.Status) } var res dynatraceResponse diff --git a/pkg/metrics/providers/newrelic.go b/pkg/metrics/providers/newrelic.go index 8ec9b5407..20bb678f4 100644 --- a/pkg/metrics/providers/newrelic.go +++ b/pkg/metrics/providers/newrelic.go @@ -111,7 +111,7 @@ func (p *NewRelicProvider) RunQuery(query string) (float64, error) { } if r.StatusCode != http.StatusOK { - return 0, fmt.Errorf("error response: %s: %w", string(b), err) + return 0, fmt.Errorf("error response: %s: %s", string(b), r.Status) } var res newRelicResponse diff --git a/pkg/metrics/providers/stackdriver.go b/pkg/metrics/providers/stackdriver.go index 9b065742b..885819421 100644 --- a/pkg/metrics/providers/stackdriver.go +++ b/pkg/metrics/providers/stackdriver.go @@ -96,7 +96,7 @@ func (s *StackDriverProvider) RunQuery(query string) (float64, error) { errStr = errStr + " Error Detail: " + d.String() } - return 0, fmt.Errorf("error requesting stackdriver: %s", err) + return 0, fmt.Errorf("error requesting stackdriver: %s", errStr) } return 0, fmt.Errorf("error requesting stackdriver: %s", err) }