Skip to content

Approve hr-eracun-v1 as an external addon - #1044

Draft
XiaoY-X wants to merge 1 commit into
mainfrom
eu3-18-hr-external-addon
Draft

XiaoY-X wants to merge 1 commit into
mainfrom
eu3-18-hr-external-addon

Conversation

@XiaoY-X

@XiaoY-X XiaoY-X commented Nov 18, 2026

Copy link
Copy Markdown

Part of EU3-18

HR eRačun add-on approval

  • Register hr-eracun-v1 (github.com/invopop/gobl.hr.eracun) as an approved external addon, so it is a valid $addons value. The addon applies the HR CIUS 2025 rules and its national extension on top of eu-en16931-v2017, for Croatian B2B invoices under Fiscalization 2.0.
  • Add it to TestApprovedAddons, regenerate the addon-list schema, and add the change file.

The name is the module's own AddonDef.Name (addon/eracun.go), copied as is, so the schema title and the runtime name agree.

This PR is independent of the hr regime (#724): the entry only makes the key recognised. A document declaring it still needs a service that imports the module.

Do not merge yet

Checks

  • go generate .: only data/schemas/tax/addon-list.json changes (the new entry).
  • go test -race ./...: pass (Go 1.25.0).
  • golangci-lint run ./addons/...: 0 issues.
  • mage changes:preview lists the entry under Added.

Pre-Review Checklist

  • Opened this PR as a draft
  • Read the CONTRIBUTING.md guide.
  • Performed a self-review of my code.
  • Added thorough tests with at least 90% code coverage.
  • Modified or created example GOBL documents to show my changes in use, if appropriate.
  • Added links to the source of the changes in tax regimes or addons, either structured or in the comments.
  • Run go generate . to ensure that the Schemas and Regime data are up to date.
  • Reviewed and fixed all linter warnings.
  • Been obsessive with pointer nil checks to avoid panics.
  • Added a file to changes/unreleased with an overview of my changes, as described in changes/README.md.
  • Marked this PR as ready for review.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (0487f2f) to head (f432055).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1044   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files         336      336           
  Lines       15422    15430    +8     
=======================================
+ Hits        14949    14957    +8     
  Misses        472      472           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant