Repository navigation
Retry provider-test readiness reads while the receipt is temporarily locked - #1972
Conversation
Keep the existing startup deadline and validate the parsed receipt. Add real Windows sharing and range-lock regression controls. Prepared jointly by Neil Colvin and OpenAI Codex.
|
@oznetmaster CI build failure due to dependabot update of engine api. I had to update Directory.Packages.props in my local build. |
Align the Console package gate with Engine API 4.0.0-beta.101.5. The API source and package dependencies are unchanged; the new package follows the Cake tool update. Complete TestAll and BuildTestAndPackage validation passed. Prepared jointly by Neil Colvin and OpenAI Codex.
|
@CharliePoole Updated The complete local The description is current and there are no merge conflicts. Ready for your review; I have not merged it. Prepared jointly by Neil Colvin and OpenAI Codex. |
CharliePoole
left a comment
There was a problem hiding this comment.
Looks good. Merged main passes all tests on my machine.
|
@oznetmaster You should be able to merge at this point. No need to request a second review. |
TestAgentProviderServerTests waits for ready.xml to exist and then loads it outside
the readiness wait. An existing file can still be temporarily unreadable on
Windows, producing the intermittent sharing-violation failure reported by @CharliePoole.
The server already publishes the file through a closed temporary file and rename.
Read and retain the XML receipt inside the existing 15-second readiness wait.
Treat only native sharing/range-lock violations as temporarily not ready; malformed
XML and other I/O failures still propagate. Child-exit, PID and endpoint checks
remain in place. The readiness correction changes only test code and retains the existing timeout.
A separate commit updates the Engine API pin from beta.101.4 to beta.101.5,
addressing the package verification failure noted by @CharliePoole. The two API
source revisions differ only in the Cake tool version; API source, target
frameworks and package dependencies are unchanged. Package verification is retained.
Validation:
reader sequence, the two lock regressions fail on each runtime; the other three
controls pass.
integration cases per runtime. Engine: 506 passed, zero failed, eight existing
skips on each target. All pre-existing per-case outcomes in all six assembly
reports are unchanged, including existing Common warnings/inconclusive cases.
directory audit pass. The unchanged-main test target also passed here; the
natural intermittent failure and the identity of Charlie's file holder remain
unproven. Controlled locking reproduces the vulnerable read without that assumption.
After updating the pin, build.ps1 --target=TestAll --target=BuildTestAndPackage
--nopush passes the build/header/analyzer checks, required and pending-acceptance
reporting targets, and verification/execution checks for all four packages.
All six required reports retain identical per-case outcomes.
The original readiness validation executed through build.ps1 --target=Test. With the pinned recipe, --test alone
selected only the Default/Build path in this checkout; both receipts are retained.
Prepared jointly by Neil Colvin and OpenAI Codex.