Repository navigation
Conversation
|
Thanks for your first contribution to SlopTotal, Konstantin! 🎉 @pablocaeg reviews every pull request personally, and you'll hear back in this thread.
Automated reply from the SlopTotal assistant. @pablocaeg reads every thread. |
explicit-preview-rules enables PLW1514 without opting into every other preview rule. The analyze.py subprocess output is decoded as UTF-8 too, which is where the Windows failure showed up (from pablocaeg#184). Co-authored-by: Priyadharshini537 <Priyadharshini537@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks @markankamaransheogarat-sys! This now covers every text-mode open in the repo, and the ruff guard keeps it that way. I pushed one commit: |
|
Merged, thanks Konstantin! That's your first contribution to SlopTotal. 🎉 #170 is closed with it. If SlopTotal is useful to you, a ⭐ on the repository helps other people find it. Automated reply from the SlopTotal assistant. @pablocaeg reads every thread. |
Summary
Fixes #170.
On Windows, Python opens files with the locale encoding (e.g.
cp1252), leading to character decoding errors when reading non-ASCII characters such as em-dashes–in dataset fixtures and calibration files.Changes
encoding="utf-8"across all text-modeopen(),.open(),.read_text(), and.write_text()calls inapp/andtests/."wb",.partdownloads).PLW1514(unspecified-encoding) withpreview = trueinpyproject.tomlso unencoded text file opens are flagged byruff.Verification
git grep -rnE "read_text\(\)" app tests scripts-> 0 matches.ruff check app tests scripts-> all checks passed.