From 4314ca3996a7668b0bc546248d0a38465a21e679 Mon Sep 17 00:00:00 2001
From: RavSinghChandan <ravchandan15@gmail.com>
Date: Sat, 14 Nov 2026 11:48:58 +0530
Subject: [PATCH] SVG: accept a <line> in a <clipPath>

---
 CHANGELOG.md         |  1 +
 fpdf/svg.py          |  9 ++++++---
 test/svg/test_svg.py | 15 +++++++++++++++
 3 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 021962aef..b235ff86f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -21,6 +21,7 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
 * Chinese translation of the [Tuto 7 - Creating PDF/A Documents](https://py-pdf.github.io/fpdf2/Tutorial-zh.html#-pdfa) tutorial section - _cf._ [issue #267](https://github.com/py-pdf/fpdf2/issues/267) - _cf._ [PR #2138](https://github.com/py-pdf/fpdf2/pull/2138) - thanks to @zheng-guannan577*
 * `FPDF.write_html()` makes the `id` of an element, and the `name` of an `<a>`, a named destination, so that `<a href="#...">` links within the document work, like in browsers, instead of raising `FPDFException: Named destination ... was referenced but never set` - thanks to @RavSinghChandan
 ### Fixed
+* SVG: a `<line>` in a `<clipPath>` no longer fails with `TypeError: ShapeBuilder.line() takes 2 positional arguments but 3 were given`; it has no area, so it clips everything away, as in browsers - thanks to @RavSinghChandan
 * SVG: an `@import`, `@charset` or other at-rule without a block at the start of a `<style>`, such as the `@import` of a Google Font, no longer hides the CSS rule that follows it; a `;` inside its URL, as in `wght@600;700`, is part of the URL - thanks to @RavSinghChandan
 * `FPDF.write_html()`: a link with `href="#"`, as in the "Back to top" links of many web pages, now goes to the top of the document, like in browsers, instead of making `output()` fail with `FPDFException: Named destination '' was referenced but never set` - thanks to @RavSinghChandan
 * `FPDF.output()` no longer fails with `struct.error: unpack requires a buffer of 2 bytes` for a font with Apple bitmap tables, such as the `Geneva.ttf` and `Cochin.ttc` of macOS: their `bdat` and `bloc` tables are now dropped when subsetting, like the `EBDT` and `EBLC` tables they correspond to - thanks to @RavSinghChandan
diff --git a/fpdf/svg.py b/fpdf/svg.py
index 1dd8677a7..e7d3c0f34 100644
--- a/fpdf/svg.py
+++ b/fpdf/svg.py
@@ -1346,14 +1346,17 @@ def ellipse(cls, tag: "Element", clipping_path: bool = False) -> PaintedPath:
         return path
 
     @classmethod
-    def line(cls, tag: "Element") -> PaintedPath:
-        """Convert an SVG <line> into a PDF path."""
+    def line(cls, tag: "Element", clipping_path: bool = False) -> PaintedPath:
+        """
+        Convert an SVG <line> into a PDF path. In a <clipPath>, it has no area, so it
+        clips everything away, as in browsers.
+        """
         x1 = resolve_length(tag.attrib.get("x1", "0"))
         y1 = resolve_length(tag.attrib.get("y1", "0"))
         x2 = resolve_length(tag.attrib.get("x2", "0"))
         y2 = resolve_length(tag.attrib.get("y2", "0"))
 
-        path = cls.new_path(tag)
+        path = cls.new_path(tag, clipping_path)
         path.move_to(x1, y1)
         path.line_to(x2, y2)
         return path
diff --git a/test/svg/test_svg.py b/test/svg/test_svg.py
index 97e484c27..05f97008e 100644
--- a/test/svg/test_svg.py
+++ b/test/svg/test_svg.py
@@ -1153,6 +1153,21 @@ def test_svg_use_of_use_of_nothing(self, referenced, caplog):
         assert outer.path_items[0].path_items == []
         assert "#clone" not in caplog.text
 
+    def test_svg_line_in_clip_path(self):
+        """A <line> has no area, so a clipping path made of it clips everything away."""
+        pdf = fpdf.FPDF()
+        pdf.compress = False
+        pdf.add_page()
+        svg = fpdf.svg.SVGObject(
+            '<svg xmlns="http://www.w3.org/2000/svg" width="10" height="10">'
+            '<clipPath id="c"><line x1="0" y1="5" x2="10" y2="5"/></clipPath>'
+            '<rect width="10" height="10" fill="red" clip-path="url(#c)"/></svg>'
+        )
+        assert isinstance(svg.cross_references["#c"], fpdf.drawing.ClippingPath)
+        svg.draw_to_page(pdf)
+        output = bytes(pdf.output()).decode("latin-1")
+        assert "0 5 m 10 5 l W n 0 0 m 0 0 10 10 re f" in output
+
     def test_svg_display_none_referenced(self):
         """An element in a hidden group can still be drawn by a <use>."""
         svg = fpdf.svg.SVGObject(