Repository navigation
Scope the log assertions of the release tests to their session, guard the messages of runOr, surface fatal errors of a disposal, fixes #239 - #260
Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
… the messages of runOr, and throw a fatal error of the disposal of the compiler, fixes #239 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VACgNo6bfV3d3xcHLG4QA
…he block under a fatal error of the message of runOr, fixes #239 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VACgNo6bfV3d3xcHLG4QA
The tests merged with #235 passed the executor as a trailing lambda, which binds to newReplDisposable, the last parameter since #239. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VACgNo6bfV3d3xcHLG4QA
morisil
force-pushed
the
issue-239-release-tests
branch
from
November 12, 2026 19:58
c60e254 to
1d43b96
Compare
Member
Author
|
Rebased onto Conflicts resolved:
New commit 1d43b96: three tests added by #266 passed the session's 🤖 Generated with Claude Code |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #239
Summary
script-session-<id>:.runOr: the message is guarded like kotlin-logging'stoStringSafe(a fatal error rethrown, with the block's failure suppressed), its parameter renameddescribe(no longer shadowing the builder'smessage), the level defaults toDEBUG, andreadOris gone.Disposer.disposenever throws a disposable's failure itself — the compiler's logger throws anAssertionErrorcaused by it — so a fatal error never reachedisFatal. The newdisposeTreeunwraps it (the first failure only — pinned byDisposeTreeTest);createRepl(both after a failed declaration of the properties and in its catch, viamostSevere) andclose()use it, the latter passing it to the session thread's uncaught exception handler.failingSessionclosed in thefinally; the temp directories ofSnippetDependencyResolverTestcreated inside thetry.MavenVersionLookup.closedno longer suggests thread safety; thenewReplDisposableseam is the last parameter, so a trailing lambda meant forexecutorno longer compiles there.CLAUDE.md: dispose throughdisposeTree, re-check the compiler logger's wrapping after a Kotlin upgrade.Review rounds
Disposer/DefaultLoggerwrapping confirmed in the bytecode. A short round 2 anyway: the KDoc and CLAUDE.md overstated the coverage (first failure only), the CLAUDE.md entry was misplaced, the block's failure suppressed under a fatal error of the message../gradlew buildgreen (withcheckKotlinAbi);releaseAll/mostSeverechecked for a fatal error winning and no self-suppression.Follow-up
runOr, cleanups.🤖 Generated with Claude Code
https://claude.ai/code/session_019VACgNo6bfV3d3xcHLG4QA