Repository navigation
Modernize the docs build toolchain - #2495
Merged
Merged
Conversation
The docs job has failed on every run since at least February. It pinned Sphinx to 3.0.3 (2020) while leaving Jinja2 unbounded, so pip resolved Jinja2 3.1, which dropped environmentfilter, and sphinx.util.rst failed to import before any page was read. Move to current Sphinx and furo, and bound both so a future major cannot break the build unnoticed. The build otherwise needed no changes; the manim-example directive works as is. Pin the interpreter with setup-python rather than inheriting whatever ubuntu-latest ships, and drop the manimlib install along with the setuptools and pango packages it needed. Nothing in docs/source uses autodoc, so the build never imported manimlib. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs job has failed on every run since at least February. It pinned Sphinx to 3.0.3 (2020) while leaving Jinja2 unbounded, so pip resolved Jinja2 3.1, which dropped environmentfilter and sphinx.util.rst failed to import before any page was read.
Move to current Sphinx and furo, and bound both so a future major cannot break the build unnoticed. The build otherwise needed no changes; the manim-example directive works as is.
Pin the interpreter with setup-python rather than inheriting whatever ubuntu-latest ships, and drop the manimlib install along with the setuptools and pango packages it needed. Nothing in docs/source uses autodoc, so the build never imported manimlib.