Repository navigation
Preserve Personal Dictionary by resolving settings keys - #94
Merged
Akshayykadam merged 1 commit intoOct 25, 2026
Merged
Conversation
Akshayykadam
marked this pull request as ready for review
October 25, 2026 11:48
Owner
|
Merged! Thank you @akashmahedy for the thorough root-cause analysis, clean key-resolution approach, and adding regression tests. Verified locally:
Appreciate the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the Gboard 18.5.3 base, settings cleanup mistakes
settings_header_dictionary(0x7f140a6e) for Help andsettings_header_physical_keyboard(0x7f140a77) for Rate. This deletes the Dictionary menu even though its native implementation remains packaged.Resolve preference keys through the current base's default string resources, then remove only the exact Help/Rate keys or native RateUsPreference class. Preserve other entries and replace the old numeric-ID, title-substring and “after About” heuristics. Add regressions for both settings layouts, reused IDs, aliases and unknown entries.
Fixes #91.
Validation:
git diff --checkpassed; independent code review found no blockers.:patches:test --tests '*GboardPackageRenameTransformTest'could not reach compilation because the declaredapp.morphe.patches:1.3.3plugin could not resolve from the configured repositories.