Repository navigation
fix(http): conditionally pass enable_cleanup_closed for older Python - #3909
Open
user-Param wants to merge 4 commits into
Open
user-Param wants to merge 4 commits into
user-Param wants to merge 4 commits into
Conversation
Author
|
All tests pass and the fix addresses a real issue. Would appreciate a review! |
…peWorX#3900) Only pass enable_cleanup_closed=True to aiohttp's TCPConnector on Python versions that need it (< 3.12.8 or 3.13.x < 3.13.1). On newer versions, aiohttp ignores the parameter and emits a DeprecationWarning, which breaks tests run with -W error. Fixes ApeWorX#3900.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3900 - AsyncHTTPProvider was passing enable_cleanup_closed=True unconditionally, triggering a DeprecationWarning on Python 3.12.8+ and 3.13.1+. The fix only passes the flag on older Python versions where the CPython bug #118960 is not fixed.