Repository navigation
Multi value - #3055
Open
JairusSW wants to merge 7 commits into
Open
Multi value#3055JairusSW wants to merge 7 commits into
JairusSW wants to merge 7 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for the Multi-Value Proposal. For a tuple type to be considered for
multi-value, it must be explicitly marked withreadonlyfirst.Related: #1633 #1425
So far, this adds basic compiler/binaryen support for outputting multi-value returns, but does not support things like indexing yet
I'm thinking that the next PR should add support type checking for tuples/multi-values, support indexing, and add an SROA pass to identify array literals vs tuples. After that, full support for tuples probably based off of warpo's implementation