Repository navigation
Preserve ASIM canary visibility diagnostics on shared deadline expiry - #15488
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
adbhogeGit
marked this pull request as ready for review
October 30, 2026 17:35
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
adbhogeGit
marked this pull request as draft
October 30, 2026 17:42
adbhogeGit
marked this pull request as ready for review
October 30, 2026 18:41
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Malformed visibility timestamps raise an unhandled ValueError, leaving targetVisibility.status as not-run and causing artifacts and reports to misrepresent a failed visibility check.
1 open issue
What changed in this PR
This PR improves ASIM ingestion-time validation diagnostics when the shared canary deadline expires. It preserves visibility evidence and makes report outcomes reflect completed validation stages without claiming to resolve the ingestion timeout.
Changes:
- Preserve per-timestamp observations in deadline errors while retaining original exception details.
- Persist target-visibility outcomes and derive ingestion and schema status from validation evidence.
- Add regression coverage and document reporting semantics.
| File | Description |
|---|---|
.script/tests/asimParsersTest/ingestTimeParser/tests/test_asim_ingestion_workflow.py |
Tests visibility, schema, legacy-artifact, and downstream reporting outcomes. |
.script/tests/asimParsersTest/ingestTimeParser/tests/test_asim_ingestion_harness.py |
Tests deadline diagnostics, error preservation, and visibility persistence. |
.script/tests/asimParsersTest/ingestTimeParser/README.md |
Documents visibility diagnostics and evidence-based reporting. |
.script/tests/asimParsersTest/ingestTimeParser/asim_ingestion/workflow/reporting.py |
Uses visibility and schema evidence to determine stage outcomes. |
.script/tests/asimParsersTest/ingestTimeParser/asim_ingestion/azure/runner.py |
Records explicit target-visibility results in validation artifacts. |
.script/tests/asimParsersTest/ingestTimeParser/asim_ingestion/azure/client.py |
Preserves the latest row observations when the shared deadline expires. |
Review effort: Balanced
Comment on lines
+294
to
+301
| except HarnessError as exc: | ||
| result["targetVisibility"] = { | ||
| "status": "failed", | ||
| "error": _error_payload( | ||
| exc, | ||
| include_observed_query_table=True, | ||
| ), | ||
| } |
Derrick Lee (yummyblabla)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Required items, please complete
Change(s):
targetVisibilityoutcome in validation artifacts. Report parser ingestion as passed only when upload and target visibility passed; retain the existing public report-stage keys and nest visibility evidence underparserIngestion.schemafromoutputValidation.schemaValidationonly; missing evidence remains not-run even when the DCR exists. That evidence is emitted after ASimDataTester succeeds and is authoritative for parser-DCR output, not a separate ASimSchemaTester execution.Reason for Change(s):
query, messageValidation deadline expired., and null details.schemaValidationevidence was never produced.Version Updated:
Testing Completed:
pythoncommand is a Windows Store alias.& 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_ingestion_harness.py"-- 28 tests passed.& 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_ingestion_workflow.py"-- 43 tests passed.& 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"-- 164 tests passed.DeadlineResponse.& 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe' -m compileall -q ".script\tests\asimParsersTest\ingestTimeParser"andgit diff --checkpassed.Checked that the validations are passing and have addressed any issues that are present:
Output path must not replace the source fixturediagnostic is expected; the suite exits successfully.masterwas not found; it is a configuration warning, not a code alert.