Repository navigation
[ASIM] Fix ITP workflow regarding ASimDnsActivityLogs ASimDataTester with datetime/string columns - #15509
Merged
Derrick Lee (yummyblabla) merged 1 commit intoOct 30, 2026
Conversation
hunngu-ms
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s):
ASimDnsActivityLogscolumns to logical ASIM types before invokingASimDataTester:ThreatFirstReportedTimeandThreatLastReportedTimetodatetime, andThreatOriginalRiskLeveltostring._d/_scolumns, falling back to casts of the legacy columns. Usecolumn_ifexiststo handle missing column variants.ASimDnsActivityLogs; ingestion transforms, parser output, and QTP/parity queries are unchanged.Reason for Change(s):
stringand the original threat risk level asint, while the logical ASIM schema expectsdatetimeandstring, respectively.Version Updated:
Testing Completed:
python -m unittest discover -s '.script\tests\asimParsersTest\ingestTimeParser\tests' -p 'test_asim_ingestion_validation.py' -k QueryConstructionTests- before the fix, failed as expected: the new DNS regression test detected the missing normalization (6 tests, 1 failure).python -m unittest discover -s '.script\tests\asimParsersTest\ingestTimeParser\tests' -p 'test_asim_ingestion_validation.py'- passed after the fix: all 25 tests.git --no-pager diff --check- passed.Checked that the validations are passing and have addressed any issues that are present: