Repository navigation
Generate JavaScript test bundles during the build - #1966
Merged
Merged
Conversation
Replace the tracked Webpack output with a custom build command that writes all seven bundles into the runtime Assets directory. Track the authored scripts and bundler inputs so edits and missing outputs regenerate the bundles, and force emission to keep no-change builds incremental. Keep manual dist output ignored. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
bghgary
marked this pull request as ready for review
October 23, 2026 22:27
bghgary
requested review from
bkaradzic-microsoft
and
a balanced review from Copilot
October 23, 2026 22:27
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in the build-time bundle generation or asset integration; builds were not executed.
No open issues 🎉
What changed in this PR
Moves UnitTests JavaScript bundle generation into the CMake build so tests use current TypeScript sources without committing generated bundles.
Changes:
- Generates test bundles directly into the configuration-specific
Assetsdirectory. - Tracks TypeScript sources and bundling configuration as build dependencies.
- Removes six committed JavaScript bundles.
| File | Description |
|---|---|
Apps/UnitTests/JavaScript/dist/tests.shaderCompilation.comprehensiveGLSL.js |
Removes the generated shader-compilation bundle. |
Apps/UnitTests/JavaScript/dist/tests.shaderCache.basicScene.js |
Removes the generated shader-cache bundle. |
Apps/UnitTests/JavaScript/dist/tests.externalTexture.render.js |
Removes the generated texture-rendering bundle. |
Apps/UnitTests/JavaScript/dist/tests.externalTexture.msaa.js |
Removes the generated multisample texture bundle. |
Apps/UnitTests/JavaScript/dist/tests.externalTexture.layerCount.js |
Removes the generated texture-layer-count bundle. |
Apps/UnitTests/JavaScript/dist/tests.externalTexture.deviceLoss.js |
Removes the generated texture-device-loss bundle. |
Apps/UnitTests/CMakeLists.txt |
Adds build-time bundling, dependency tracking, and generated asset integration. |
Review effort: Balanced
bkaradzic-microsoft
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
JavaScript test bundles should reflect the current TypeScript sources without requiring generated files to be committed.