Repository navigation
CI: raise Nightly job timeout to 180 minutes - #1968
Open
bkaradzic-microsoft wants to merge 2 commits into
Open
bkaradzic-microsoft wants to merge 2 commits into
bkaradzic-microsoft wants to merge 2 commits into
Conversation
The Nightly job has no explicit timeout, so it gets Azure's 60 minute default. Packaged VisualizationTests grew from ~34 to ~39 min, and both nightly runs with BabylonJS#1889 (61325, 61329) were cancelled before uploading the Playground artifact Babylon.js CI consumes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
bkaradzic-microsoft
changed the title
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The timeout is correctly scoped to the Nightly job, with no changes to validation or artifact-publishing behavior.
No open issues 🎉
What changed in this PR
Raises the Nightly CI job timeout so longer validation runs can finish and publish packages consumed by Babylon.js.
Changes:
- Sets the
Nightlyjob timeout to 180 minutes. - Adds a comment explaining why the default 60-minute limit is insufficient.
| File | Description |
|---|---|
nightly.yml |
Increases the Nightly job timeout and documents the reason. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The BabylonNative Nightly CI pipeline hasn't published a build since #1889 landed:
The
Nightlyjob has notimeoutInMinutes, so Azure applies its 60-minute default. As more validation tests are enabled, the packaged visualization run has grown, and the job now overruns before publishingBabylonNativeNightlyPlayground.Babylon.js CI only uses fully succeeded nightly runs, so it is still testing against bac047b. That is why BabylonJS/Babylon.js#19041 keeps failing on "GUI Gradient Linear with transparency", which #1889 addresses. Each failure re-runs the whole native suite 3 times, which then hits B.js's own 90-minute limit.
Fix
Set
timeoutInMinutes: 180on theNightlyjob.Run 61329 also had an unrelated agent-lost failure on Android macOS JavaScriptCore during the ccache restore.