Repository navigation
cheri_exec: Remove always-true SV_CHERI condition - #2753
Merged
Merged
Conversation
We only ever call cheri_sigcode_capability for SV_CHERI, and other parts of its implementation would be broken were that not the case, so delete this check added in 87dd9fe ("struct vmspace: make vm_shp_base a capability").
bsdjhb
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only ever call cheri_sigcode_capability for SV_CHERI, and other parts
of its implementation would be broken were that not the case, so delete
this check added in 87dd9fe ("struct vmspace: make vm_shp_base a
capability").