Repository navigation
user_connectat: correctly pass fd through - #2754
Merged
Merged
Conversation
In the original adaptation of connect/connectat to use user_connectat in CheriBSD, I failed to pass the fd through in the connectat case and always passed AT_FDCWD. This did trigger failures in the unix_connectat test which I somehow missed in prior test runs. Reported by: llm-postcr (cherry picked from commit 431cc94c0395205f7859d5f65289f9f2ebbe8162)
bsdjhb
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original adaptation of connect/connectat to use user_connectat in CheriBSD, I failed to pass the fd through in the connectat case and always passed AT_FDCWD. This did trigger failures in the unix_connectat test which I somehow missed in prior test runs.
Reported by: llm-postcr
(cherry picked from commit 431cc94c0395205f7859d5f65289f9f2ebbe8162)
This fixes a bug in 8a26c8f