Repository navigation
fix: skip gas settlement when virtual calls do not charge gas - #3621
Merged
peilun-conflux merged 2 commits intoOct 28, 2026
Merged
peilun-conflux merged 2 commits into
peilun-conflux merged 2 commits into
Conversation
ChenxingLi
approved these changes
Oct 27, 2026
ChenxingLi
left a comment
ChenxingLi
left a comment
Contributor
There was a problem hiding this comment.
@ChenxingLi reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on peilun-conflux).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual calls with gas charging disabled still refunded gas to the sender and deducted fees from the total eSpace balance. The uncharged refund could overflow the sender's balance, causing an
eth_callpanic.Guard both settlement operations with the existing
charge_gasflag. Add regression tests for the overflow and normal gas charging.This change is