Repository navigation
ci: update Tokio and document crypto-bigint exception - #3622
Closed
peilun-conflux wants to merge 1 commit into
Closed
peilun-conflux wants to merge 1 commit into
peilun-conflux wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
No high-confidence defects found in the changed configuration. The inspected signing and ECDH paths use libsecp256k1, while the REVM P-256 integration passes verification inputs only. Generated files excluded from findings as requested: Validation was static and read-only; no builds, tests, or audit commands were executed. Upstream advisory details and dependency implementations were not independently verified. Reviewed by gpt-6.1-sol · Input: 42 · Output: 3.5K · Cached: 522.5K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Tokio to 1.53.3 for RUSTSEC-2026-0386.
Add a temporary crypto-bigint exception for RUSTSEC-2026-0387, which concerns timing leaks from arithmetic on secret operands. The inspected node paths only verify signatures and recover public keys using public inputs. Neither private keys nor secret signing nonces enter these computations, so timing variations cannot reveal additional private-key information through these paths. Conflux secp256k1 signing and ECDH use libsecp256k1.
This change is