Repository navigation
fix(core): show the id when a take or DM name is blank - #6721
Open
davidfarah2003 wants to merge 1 commit into
Open
davidfarah2003 wants to merge 1 commit into
davidfarah2003 wants to merge 1 commit into
Conversation
A take notice, an anycast status, and a direct-message receipt printed a whitespace-only holder or recipient name as a blank. They now show the id. A name that still contains a character, including a leading space, stays.
Contributor
Author
|
Please stop opening one pull request per blank-name surface. Thirty-eight have been opened today; each needs its own full suite run and they conflict in the shared suite files. Eighteen are combined in #6692. The fourteen still open (#6694 to #6721) get combined into one second pull request after #6692 merges; please do not push to them. Further surfaces: comment on #6638 and send one patch for all of them rather than new issues and pull requests. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6720.
A take notice printed the holder's name, so a whitespace-only name left a gap (
(local.blank) took your @reviewer request) and a newline split the line. An anycast status did the same (taken by (local.blank),Ask with cotal_dm). A direct-message receipt did the same (Sent to ., and the offline sentence named that blank three times).The notice, the status, and the receipt show the id when the name is missing or only whitespace. A name that contains a character stays, including a leading space (
ada). A real name is still printed in front of its id. A redelivery notice and a refused take use the same id.pnpm exec tsx extensions/connector-core/smoke/tool-blank-name.smoke.tspassed 13 checks. The take notice is the textdecideTakestores. The status and the DM receipt come from the realcotal_anycastandcotal_dmtools.docs/mcp-tools.mdxcovers the notice, the status, and the DM receipt.