Repository navigation
Conversation
Member
|
Patches haven’t been properly rebuilt; make sure to run the rebuild all task |
Author
|
Rebuilt, thanks. The feature patches on top of PlayerList had shifted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author: Wesley Breukers
Fixes joins failing once about 1,000 players are online. The joining player gets one player info packet with every online player, about 2KB each with a signed skin and chat key, and past ~1,000 entries it exceeds the 2MB frame limit. We saw this in production: joiners kicked with
Packet too large: size 2097572at ~1,000 online. The list is now sent in packets of 200; the client adds them to the same list, so nothing changes for it.