Skip to content

fix(google): fail closed on unsupported partial function arguments - #27

Open
hypn4 wants to merge 2 commits into
Deuz-AI:mainfrom
hypn4:fix/google-partial-function-arguments
Open

hypn4 wants to merge 2 commits into
Deuz-AI:mainfrom
hypn4:fix/google-partial-function-arguments

Conversation

@hypn4

@hypn4 hypn4 commented Oct 16, 2026 •

Copy link
Copy Markdown

Fixes #26. Related tracking: #22.

Changes

Reject explicit streamFunctionCallArguments: true through the active provider key before HTTP, including when canonical tool configuration would otherwise mask the request. Reject received partialArgs/willContinue frames with a non-retryable error before executable work from the turn. Validate the whole frame before emitting its tool deltas. Keep complete and zero-argument calls unchanged.

The 18 regressions include buffered, streamed and native agent routes with zero tool side effects on the partial cases. This is a safety boundary only; full incremental argument assembly remains open in #22.

Validation scope

Base: 393439711aca3e46a1ec26b3aa2506de5a1fe922. The added regressions use scripted HTTP/SSE responses and synthetic credentials. They do not establish live model availability or service acceptance. No live Google model, authentication or cloud-resource operation was made. Dependency manifests and lockfiles are unchanged. No generated dist files are committed.

Final verification

Checked head: 09fe5cb6628450fcfcef0f4380ac70be82873d1b. Focused tests: 18/18 passed; core typechecking and the branch-specific build/bundle-size gate passed. The tests use mocked HTTP/SSE and do not make live model requests.

An isolated combined tree containing #21, #23 and these follow-ups passed 7,685 core tests with 407 skipped and one pre-existing macOS Docker command-line-length failure, also reproduced on the unchanged base. Core type tests (131) and React tests (156) passed. The combined tree exceeds several existing bundle-size budgets even though each branch passes separately; integration requires reviewing the cumulative cost. The cache guard and partial-argument guard also touch the same adapter insertion point; both must be retained when resolving that merge.

The combined built package also passed runtime compatibility, public API/ESM/CJS contract, documentation references, strict publint and Are The Types Wrong checks. Packing was run with npm 11 after an explicit build and lifecycle scripts disabled so package inspection did not rebuild or remove declaration artifacts. Lint has no errors; the seven existing live-test warnings remain.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native partial function-argument frames need a fail-closed boundary

1 participant