Repository navigation
Conversation
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26. Related tracking: #22.
Changes
Reject explicit
streamFunctionCallArguments: truethrough the active provider key before HTTP, including when canonical tool configuration would otherwise mask the request. Reject receivedpartialArgs/willContinueframes with a non-retryable error before executable work from the turn. Validate the whole frame before emitting its tool deltas. Keep complete and zero-argument calls unchanged.The 18 regressions include buffered, streamed and native agent routes with zero tool side effects on the partial cases. This is a safety boundary only; full incremental argument assembly remains open in #22.
Validation scope
Base:
393439711aca3e46a1ec26b3aa2506de5a1fe922. The added regressions use scripted HTTP/SSE responses and synthetic credentials. They do not establish live model availability or service acceptance. No live Google model, authentication or cloud-resource operation was made. Dependency manifests and lockfiles are unchanged. No generated dist files are committed.Final verification
Checked head:
09fe5cb6628450fcfcef0f4380ac70be82873d1b. Focused tests: 18/18 passed; core typechecking and the branch-specific build/bundle-size gate passed. The tests use mocked HTTP/SSE and do not make live model requests.An isolated combined tree containing #21, #23 and these follow-ups passed 7,685 core tests with 407 skipped and one pre-existing macOS Docker command-line-length failure, also reproduced on the unchanged base. Core type tests (131) and React tests (156) passed. The combined tree exceeds several existing bundle-size budgets even though each branch passes separately; integration requires reviewing the cumulative cost. The cache guard and partial-argument guard also touch the same adapter insertion point; both must be retained when resolving that merge.
The combined built package also passed runtime compatibility, public API/ESM/CJS contract, documentation references, strict publint and Are The Types Wrong checks. Packing was run with npm 11 after an explicit build and lifecycle scripts disabled so package inspection did not rebuild or remove declaration artifacts. Lint has no errors; the seven existing live-test warnings remain.