Skip to content

Second asset selection algorithm - #1574

Draft
tsmbland wants to merge 5 commits into
continuous_capacitiesfrom
single_optimisation_investment
Draft

tsmbland wants to merge 5 commits into
continuous_capacitiesfrom
single_optimisation_investment

Conversation

@tsmbland

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@tsmbland
tsmbland force-pushed the single_optimisation_investment branch 2 times, most recently from adc2127 to 76d2ba2 Compare November 4, 2026 10:23
@tsmbland
tsmbland force-pushed the single_optimisation_investment branch from 9259885 to 0cc6900 Compare November 4, 2026 14:12
@tsmbland tsmbland changed the title Single optimisation investment Second investment algorithm Nov 4, 2026
@tsmbland tsmbland changed the title Second investment algorithm Second asset selection algorithm Nov 4, 2026
@tsmbland
tsmbland force-pushed the single_optimisation_investment branch from 0cc6900 to 6f36a6a Compare November 9, 2026 16:18
@tsmbland
tsmbland added this pull request to stack #1584 November 10, 2026 11:27
@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.97717% with 22 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (continuous_capacities@b2a4f17). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/simulation/investment/portfolio/constraints.rs 92.85% 7 Missing and 5 partials ⚠️
src/asset/capacity.rs 57.14% 3 Missing ⚠️
src/simulation/investment/portfolio.rs 96.55% 2 Missing and 1 partial ⚠️
...rc/simulation/investment/portfolio/optimisation.rs 98.21% 0 Missing and 2 partials ⚠️
src/simulation/investment/portfolio/costs.rs 93.75% 1 Missing ⚠️
src/simulation/investment/portfolio/debug.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             continuous_capacities    #1574   +/-   ##
========================================================
  Coverage                         ?   89.52%           
========================================================
  Files                            ?       68           
  Lines                            ?     9687           
  Branches                         ?     9687           
========================================================
  Hits                             ?     8672           
  Misses                           ?      687           
  Partials                         ?      328           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tsmbland and others added 5 commits November 10, 2026 11:53
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A new `portfolio` agent type chooses the capacities of all existing and candidate
assets together in a single optimisation, rather than selecting assets one at a
time. Candidates have continuous capacity (or discrete if the process has a
tranche size). Debug output goes to debug_asset_selection_portfolio*.csv.

Agents of different types can be mixed in a model. The default remains
`competitive`, so existing models are unaffected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
tsmbland force-pushed the single_optimisation_investment branch from 3d1544b to 45b399a Compare November 10, 2026 11:53
@tsmbland
tsmbland removed this pull request from stack #1584 November 10, 2026 15:58
@tsmbland
tsmbland added this pull request to stack #1588 November 10, 2026 16:00
@tsmbland
tsmbland removed this pull request from stack #1588 November 11, 2026 16:29
@tsmbland
tsmbland added this pull request to stack #1594 November 11, 2026 16:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant