Skip to content

Refactor to allow multiple simulation modes - #1592

Draft
tsmbland wants to merge 8 commits into
remove_shadow_scarcity_strategiesfrom
simulation_mode_refactor_v2
Draft

Refactor to allow multiple simulation modes#1592
tsmbland wants to merge 8 commits into
remove_shadow_scarcity_strategiesfrom
simulation_mode_refactor_v2

Conversation

@tsmbland

@tsmbland tsmbland commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc
  • Update release notes for the latest release if this PR adds a new feature or fixes a bug
    present in the previous release

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

tsmbland and others added 8 commits November 11, 2026 14:52
@tsmbland
Drop unused base-year agent dispatch
5191f5c 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Extract shared solver utilities into crate::optimisation
616c31e 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Introduce FlowEstimator seam for dispatch in the agent loop
331b4fa 
Move the partial dispatch runs out of the shared investment and market
code into a PartialDispatch implementation, and remove shadow prices
from Prices.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Create simulation::system_dispatch submodule
927a8f9 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Move dispatch debug output into system_dispatch
df8f384 
output.rs no longer depends on dispatch internals.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Add simulation_protocol model setting
8cf57b6 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Document simulation protocols
3612270 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
Make shared price doc comments protocol-neutral
8c50734 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@tsmbland
tsmbland added this pull request to stack #1594 November 11, 2026 16:30

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tsmbland