Repository navigation
#980 [Mod] fix: DOLIMEET_EMAIL_TEMPLATE_COMPLETION_CERTIFICATE n'est plus écrite, elle n'était lue nulle part - #981
Merged
nicolas-eoxia merged 1 commit intoOct 30, 2026
Conversation
…N_CERTIFICATE, read nowhere init() kept the id of the completion certificate email template in this constant (Evarisk#596), and no code ever read it: the template is picked by hand when sending, and the DOLIMEET_EMAIL_TEMPLATE_SET counter guards the step. The constant only made the Saturne email templates overview believe a setting sends the template. init() no longer writes it, and deletes the one existing installations hold. The template itself is still created. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nicolas-eoxia
deleted the
fix/980-drop-unread-certificate-template-const
branch
October 30, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #980
Pourquoi
À l'activation,
modDoliMeet::init()range l'identifiant du modèle d'email « Certificat_Réalisation » dansDOLIMEET_EMAIL_TEMPLATE_COMPLETION_CERTIFICATE(#596). Aucun code ne relit cette constante :DOLIMEET_EMAIL_TEMPLATE_SET.Elle ne servait qu'à faire croire à la vue d'ensemble des modèles d'email de Saturne (Evarisk/Saturne#1811) qu'un réglage envoie ce modèle. #978 l'avait volontairement laissée hors de ses déclarations, et elle restait la seule constante affichée brute dans « Utilisé par ».
Ce que fait la PR
init()ne l'écrit plus. Le modèle « Certificat_Réalisation » continue d'être créé.init()supprime celle que les installations existantes ont en base (dolibarr_del_const, sans effet quand elle n'existe pas). La suppression se fera à la prochaine montée de version, par la réinitialisation de l'accueil Saturne.Recherche faite dans tous les modules de
htdocs/custom: la constante n'est lue nulle part.Tests
dolibarr_del_const()rejouée en CLI dans une transaction annulée. La constante disparaît, un second passage ne lève pas d'erreur, et le rollback la restaure.php -l,dev/ci/lang-parity.phpet PHPStan (phpstan.neon) sans erreur sur le descripteur.init()complet. Le lancer aurait réinitialisé DoliMeet sur la base locale partagée.🤖 Generated with Claude Code