Repository navigation
Add SocketError without Zinc's removed server helper - #292
Merged
Merged
Conversation
MCPSocketSafeZnServer built its read termination set with ZnMultiThreadedServer>>#exceptionSet:, which Pharo 15 build 110 removed with its Zinc sync (upstream moved it to ZnUtils in 2024). SocketError exists on every Pharo MCP supports, so it is added directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pharo 15 CI fails on main since build 110:
MCPSocketSafeZnServer >> #readRequestTerminationExceptionSetsends#exceptionSet:, which Pharo's Zinc sync (pharo-project/pharo#20203) removed fromZnMultiThreadedServer, as upstream Zinc did in 2024 when it moved the helper toZnUtils.The other failures come from the same send: the contract test flags it as unimplemented, and the server's forked processes fail on it.
SocketErrorexists on every Pharo MCP supports, so the set adds it directly. Pharo 12 and 13 still need it added; from 14 on the parent's set already has it.