Repository navigation
Conversation
The last commit on main left four files unformatted and image_ops.rs with clippy errors (chunks_exact_mut with a constant size, unwrap in tests), so the pre-commit checks failed before any change. Formatting only, plus as_chunks_mut and expect in the test module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N9yLeqPvdKPLsTNWG9Kg4h
As in Animate: a Bone tool drag from one instance to another links them with a bone and moves both to a new armature layer whose keyframes are poses; a drag from an instance in an armature adds a bone below it. The Selection tool poses: a joint, its instance or a bone (by its tip) is pulled toward the pointer by cyclic coordinate descent within the joints' rotation limits, and a root moves the whole armature. A pose made inside a keyframe splits it so the first part tweens into it. - flare-document: Content::Armature (rig of up to 256 joints, each carrying an instance, plus a per-key pose), RigEdit, validation (one rig per layer, instances counted once per layer, not on masks/guides). - flare-eval: armature instances placed through their joint matrices, tweened between poses, keeping their symbol clock across poses; one level item per joint for publishers. - flare-tools::bones: connect, reach, pose_joint, turn_joint, shift_root, set_limit, detach, release, picking and a report. A property test runs random pose/limit/detach sequences (it found that a limit must go with its bone on detach). - Storage round-trips armatures; SWF keeps the instances as the same objects through poses; XFL writes each pose as posed instances, with a warning. - Desktop and browser: Bone tool in the strip, bone overlay, live IK preview, Properties (turn, limits, Remove bone, Release armature), in all eight languages. - CLI: flare bone add|pose|limit|detach|release, flare bones; info marks armature layers. MCP: add_bone, pose_bone, limit_joint, detach_bone, release_armature, list_bones. - Docs: ARCHITECTURE, UI, SURFACES, ROADMAP, CHANGELOG, README and its translations (the roadmap item now names what remains: bones inside shapes and the Bind tool). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N9yLeqPvdKPLsTNWG9Kg4h
…heck reads test_surfaces.py takes what is outside the parentheses as the answer, so "yes, as a download ..." failed the check on main. The words are the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N9yLeqPvdKPLsTNWG9Kg4h
IMPORT_EXTENSIONS listed .fcp, .ppm, .kwz, OpenToonz (.tnz, .tlv, .pli, .tzu) and Moho (.moho, .mh, .mohobackup) files, which no importer reads: opening one failed with "not an XFL document". It also failed CI's test_associations, because the macOS bundle, Linux MIME types and Windows installer (rightly) do not offer them to Flare. Back to .fla, .xfl and .swf; the classify test now checks the others are not claimed, and a comment says they return with their importers (README already lists the OpenToonz formats as planned). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N9yLeqPvdKPLsTNWG9Kg4h
Contributor
|
@Cenvginer can you explain this PR? You've left no description or anything |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How it was checked
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --lockedNotes for the reviewer