Repository navigation
Log the Floodgate login message after the handshake instead of on join - #688
Open
eduardomazolini wants to merge 1 commit into
Open
eduardomazolini wants to merge 1 commit into
eduardomazolini wants to merge 1 commit into
Conversation
The "Floodgate player logged in as X joined (UUID: ...)" message was only logged on join (Spigot) / login (Bungee), so it never showed up for Bedrock players that are refused before that, for example by the server whitelist. Their Floodgate UUID was then nowhere in the console, and since the Global API does not always know the gamertag yet, there was no easy way to whitelist them. Log it right after Floodgate has verified the player in the handshake, as the existing todo suggested. This also covers Velocity, which did not log this message before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
todoinSpigotListener/BungeeListener:Why
floodgate.ingame.login_name("Floodgate player logged in as X joined (UUID: ...)") was only logged on join (Spigot) or login (Bungee). A Bedrock player refused before that, for example by the server whitelist, therefore never had their Floodgate UUID printed anywhere:Together with #304 (the Global API not knowing every gamertag yet), this left server owners without a simple way to whitelist a Bedrock player who already tried to join: the UUID needed for
whitelist.json/fwhitelist add <uuid>was not in the console.Related: #304 (
fwhitelist add <name>fails when the Global API does not know the gamertag) and #357 (whitelisting players that never joined). This PR does not change the name lookup; it makes the UUID of anyone who already tried to join available, sofwhitelist add <uuid>can be used meanwhile.What
floodgate.ingame.login_nameinFloodgateHandshakeHandler, right after the player has been verified and added (only when the handshake does not disconnect them).SpigotListenerandBungeeListener.The message key and its translations are unchanged.
Testing
./gradlew buildpasses.with no duplicate from the listener.