Skip to content

Fix CI build failure from missing numa.h - #3

Merged
khale merged 2 commits into
STRATA-5.5.0from
STRATA-5.5.0-fix-ci
Oct 20, 2026
Merged

khale merged 2 commits into
STRATA-5.5.0from
STRATA-5.5.0-fix-ci

Conversation

@plabondutta

@plabondutta plabondutta commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

CI was failing on every PR into STRATA-5.5.0 before it got to any tests.
All the build jobs stopped at the same line:

runtime/array.c:20: fatal error: numa.h: No such file or directory

The GitHub runners don't have libnuma-dev installed, and macOS and Windows
don't have libnuma at all.

This PR:

  • installs libnuma-dev in the Linux jobs (including the i386 container and
    the Hygiene build) and links with -lnuma
  • filters the macOS jobs out of the build matrix. Their definitions stay in
    the file, so changing return jobs.filter(...) back to return jobs;
    brings them back
  • disables the Windows workflow (if: false on its config job) instead of
    deleting it
  • adds a Changes entry, which the Hygiene check requires for every PR
  • removes some trailing whitespace and wraps one long comment in
    runtime/array.c, which the style check was flagging
  • adds a flambda-specific reference for tests/backtrace/event_after_prim.
    Array.make is now an OCaml wrapper (for ?far), and flambda inlines it, so
    native flambda builds print "array.ml" (inlined) in the backtrace. The
    existing reference only matched non-flambda builds.

The workflow triggers are unchanged, and nothing in the runtime behaviour
changes.

@Binkersss Binkersss left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good.

@khale
khale merged commit 4ffc1cd into STRATA-5.5.0 Oct 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants