Skip to content

rxiv-maker 1.24.3 - #14

Merged
paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.24.3
Sep 15, 2026
Merged

paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.24.3

Conversation

@paxcalpt

Copy link
Copy Markdown
Contributor

Bump to 1.24.3: equations export to DOCX as editable Office Math instead of a picture.

Copilot AI lite review requested due to automatic review settings September 15, 2026 15:18
@claude

claude Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review: rxiv-maker 1.24.3 bump

Straightforward, well-scoped version bump — only the url and sha256 lines change, and both are updated together as they should be. No changes to depends_on, install, or test do, so the diff carries low risk.

Code quality / conventions

  • Diff matches the existing formula's style (quoting, indentation, structure) — nothing to flag.
  • sha256 is a valid 64-character hex digest, and the url follows the standard PyPI files.pythonhosted.org/packages/<xx>/<yy>/<hash>/<name>-<version>.tar.gz layout, so the format is consistent with a legitimate PyPI release artifact.

Potential issues

  • I don't have network access in this review environment, so I couldn't independently re-fetch https://pypi.org/pypi/rxiv-maker/1.24.3/json to confirm the sha256 matches upstream byte-for-byte. Since Homebrew formulae pin integrity via this hash, it's worth having CI (or a maintainer) confirm brew audit --strict --online Formula/rxiv-maker.rb and a real install pass before merging, rather than relying on the diff looking well-formed.

Test coverage

  • .github/workflows/test-rxiv-maker.yml.disabled — the workflow that would brew install --build-from-source this formula on macos-14 — is currently disabled (.disabled suffix), so this bump won't be exercised by CI automatically. This is a pre-existing repo condition, not something introduced by this PR, but it does mean the version/hash correctness here is currently unverified by automation. Worth considering re-enabling that workflow (even just on formula-touching PRs) so future bumps like this one get a real install smoke test.

Security

  • No concerns — the change is a pure metadata bump (URL + hash), no install-script or dependency changes that would affect the trust boundary.

Overall: safe to merge once the hash is confirmed against the upstream PyPI release (either manually or via brew audit/CI).

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The formula update and checksum change are complete with no unresolved issues.

Pull request overview

Updates the Homebrew formula for rxiv-maker 1.24.3, which supports editable Office Math equation export in DOCX.

Changes:

  • Updated the PyPI source URL.
  • Updated the SHA-256 checksum.
File summaries
File Description
Formula/rxiv-maker.rb Bumps rxiv-maker to version 1.24.3.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@paxcalpt
paxcalpt merged commit b29249e into main Sep 15, 2026
2 checks passed
@paxcalpt
paxcalpt deleted the rxiv-maker-1.24.3 branch September 15, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants