Skip to content

rxiv-maker 1.23.2 - #7

Merged
paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.23.2
Aug 10, 2026
Merged

paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.23.2

Conversation

@paxcalpt

Copy link
Copy Markdown
Contributor

Bumps to 1.23.2. Adds rxiv docx --track-changes (1.23.0) and corrects the Zenodo deposit metadata. Release: https://github.com/HenriquesLab/rxiv-maker/releases/tag/v1.23.2

Copilot AI lite review requested due to automatic review settings August 10, 2026 19:40
@paxcalpt
paxcalpt merged commit ae139b1 into main Aug 10, 2026
2 checks passed
@paxcalpt
paxcalpt deleted the rxiv-maker-1.23.2 branch August 10, 2026 19:41

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Homebrew formula for rxiv-maker to the latest upstream release (v1.23.2), aligning Homebrew’s packaged version with the new features and metadata fixes described in the release notes.

Changes:

  • Bump rxiv-maker from 1.23.0 to 1.23.2.
  • Update the source tarball URL and corresponding SHA256 checksum.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@claude

claude Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review: rxiv-maker 1.23.0 → 1.23.2

This is a clean, minimal version bump — only the url and sha256 lines change, which matches the pattern used for previous version bumps of this formula and the other formulas in this tap (folder2md4llms.rb, taskrepo.rb). No new dependencies are introduced, and latexdiff (needed for the new rxiv docx --track-changes flag mentioned in the PR description) is already a listed dependency, so no formula changes are needed for that feature.

Checks performed:

  • Both the old and new sha256 values are well-formed 64-character hex strings (valid SHA-256 length). ✅
  • The new PyPI URL follows the standard files.pythonhosted.org path structure (<hash[0:2]>/<hash[2:4]>/<hash[4:]>/filename, 2+2+60 hex chars), consistent with a genuine PyPI-generated download link. ✅
  • I was not able to actually download the tarball and independently recompute the sha256 in this sandboxed environment (outbound network access is restricted), so I could not 100% confirm the checksum matches the published artifact.

Suggestions:

  1. Per TESTING.md, this repo's CI checksum/install verification is currently disabled due to the upstream Homebrew Core versioned-Python issue, and local testing via just release rxiv-maker (or at minimum just update/just test) is the primary safety net right now. Since this PR appears to have been opened by automation, it'd be good for a maintainer to run just test rxiv-maker (or brew install --build-from-source ./Formula/rxiv-maker.rb && brew test rxiv-maker) locally before merging, to confirm the hash and install actually succeed on macOS.
  2. Nothing else to flag — no test coverage changes are needed since the existing test do block (--version / --help) already exercises the new version generically, and no security/performance concerns are introduced by this diff itself. The main residual risk is simply "does this sha256 correctly correspond to this URL," which is best confirmed by an actual brew install run rather than static review.

Overall: looks good to merge once the checksum/install is verified locally (or by CI, once re-enabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants