Skip to content

rxiv-maker 1.23.4 - #9

Merged
paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.23.4
Sep 2, 2026
Merged

paxcalpt merged 1 commit into
mainfrom
rxiv-maker-1.23.4

Conversation

@paxcalpt

@paxcalpt paxcalpt commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Bumps the rxiv-maker formula to 1.23.4.

Upstream release: https://github.com/HenriquesLab/rxiv-maker/releases/tag/v1.23.4

Fixes bibliography entries dropping the arXiv venue: rxiv_maker_style.bst declared neither eprint nor archiveprefix, so preprint references printed as a bare title, author and year plus a DOI. References now render arXiv:2508.00836.

sha256 verified against the published PyPI sdist.

Copilot AI lite review requested due to automatic review settings September 2, 2026 19:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward version+checksum bump with no functional modifications to the formula logic or tests.

Pull request overview

Updates the Homebrew formula for rxiv-maker to the latest upstream release (v1.23.4) by refreshing the source tarball URL and checksum so Homebrew can fetch and verify the new distribution.

Changes:

  • Bumped rxiv-maker from 1.23.3 to 1.23.4.
  • Updated the PyPI sdist url and corresponding sha256 to match the new release artifact.
File summaries
File Description
Formula/rxiv-maker.rb Updates the source tarball URL and SHA-256 checksum to package rxiv-maker v1.23.4.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@claude

claude Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review: rxiv-maker 1.23.4 bump

Clean, minimal formula-bump PR — only the url and sha256 lines change, which is exactly right for this kind of update. A few notes:

Code quality

  • Diff is scoped correctly (no unrelated changes to depends_on, install, test do, etc.), consistent with how a pure version bump should look.
  • sha256 is 64 hex chars (verified length) — no truncation/typo, and both old and new PyPI URL hash-prefixes follow the expected xx/xx/… directory format, so nothing looks malformed.

Bugs / correctness

  • Nothing wrong with the formula itself. Note that I couldn't reach files.pythonhosted.org/PyPI JSON API from this sandbox to independently re-download and re-hash the sdist, so I'm trusting the PR description's claim that the sha256 was checked against the published PyPI sdist — worth a maintainer double-check (pip download --no-deps rxiv-maker==1.23.4 -d /tmp && shasum -a 256 …) before merge if that wasn't already done outside CI.

Security

  • sha256 pinning is present and updated alongside the URL, so integrity verification stays intact — good practice, no concerns.

Test coverage

  • Per TESTING.md, test-rxiv-maker.yml is currently .disabled (Homebrew core issue with versioned Python formula keywords), so this bump won't get automated CI install/test coverage — it relies on the documented local just release rxiv-maker workflow. Worth confirming that was run before merging, since that's the only verification gate right now.
  • The formula's test do block only checks --version and --help; it doesn't exercise the bibliography/arXiv-venue rendering fix mentioned in the PR description. That's reasonable to leave to rxiv-maker's own upstream test suite rather than the Homebrew formula test, so not a blocker — just flagging that the fix itself isn't verified at this layer.

Performance

  • No concerns; no changes to install steps or dependencies.

Overall: looks safe to merge, low risk, matches existing formula conventions in this repo.

@paxcalpt
paxcalpt merged commit 115e3b9 into main Sep 2, 2026
2 checks passed
@paxcalpt
paxcalpt deleted the rxiv-maker-1.23.4 branch September 2, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants