Repository navigation
Allow configuring unit-CodeList from nomenclature.yaml - #623
Merged
Merged
Conversation
dc-almeida
approved these changes
Nov 9, 2026
dc-almeida
left a comment
dc-almeida
left a comment
Contributor
There was a problem hiding this comment.
Good to merge. Since I haven't really handled climate-assessment, what's the use case for this compared to the variable codelist (which includes units)?
Member
Author
|
@dc-almeida, see https://github.com/iiasa/scse-update/issues/60, let's discuss with @phackstock next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring workflow-repos for the climate-assessment extension, I realised that it is currently not possible to add a unit CodeList via
nomenclature.yaml, so defining climate-assessment units in a database via scse-update does not work.This PR adds "unit" to the list of allowed dimensions in the config-class, and adds a test.