Repository navigation
Refactor CI Workflow Files - #83
Conversation
* Replaced depricated plt.cm.get_cmap api * Switched to newer API for getting colormap * Apply suggestions from code review Co-authored-by: Michael Denker <m.denker@fz-juelich.de> * Bumbed matplotlib min version to allign with api change --------- Co-authored-by: Michael Denker <m.denker@fz-juelich.de>
* Swapped out setup.py with pyproject.toml * Adding a architectural decision record file * Splitup into multiple adrs * upper limit on setuptooks for python 3.8 support; ADR changes * remove newer licence field from pyproject.toml since older setuptools doesn't understand it * Added statement to exclude adrs from packaging * Reinstated licence classifier as per PR review
version alone actions/checkout@v6.0, actions/setup-python@v6.2, and actions/cache@v5.0 don't exist as refs — GitHub Actions only tags major (vN) or full semver (vN.N.N), never a two-part vN.N. This was failing every job in PR #83 with "unable to resolve action" errors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PBNgnLD1qDqXsQsn15ivzk
3a82ca8 to
ea3d82b
Compare
kohlerca
left a comment
There was a problem hiding this comment.
The changes and updates in the CI workflow look good to me.
However, I identified that during the documentation build, there is a non-fatal failure in plot_patterns_hypergraph and plot_ue, which prevents the plots from showing in the documentation. I would expect those errors to fail one job in the CI.
This is somewhat independent from this refactoring PR, although we should have those errors flagged.
…ut np.stack with list comprehension in doc strings example
Thanks for going through the logs to find those silent failures! |
Looks like a good plan. |
Summary
Upgrade to new GitHub Actions versions in CI_actions.yml
Dropped redundant python-versions from docs job in favor of a single python version
Expand the tests job's Python version matrix to 3.8–3.14
Replace the docs job's dependency install (requirements-docs.txt + conda pandoc) with
apt install pandocandpip install ., keeping up with the pyproject.toml migration in Migrate packaging from setup.py to pyproject.toml #82Other general cosmetic changes also made
Document when stricter doc build options can be enforced in CI doc build