Skip to content

Refactor CI Workflow Files - #83

Merged
CozySocksAlways merged 7 commits into
masterfrom
fix/ci_matrix
Sep 15, 2026
Merged

CozySocksAlways merged 7 commits into
masterfrom
fix/ci_matrix

Conversation

@CozySocksAlways

@CozySocksAlways CozySocksAlways commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade to new GitHub Actions versions in CI_actions.yml

  • Dropped redundant python-versions from docs job in favor of a single python version

  • Expand the tests job's Python version matrix to 3.8–3.14

  • Replace the docs job's dependency install (requirements-docs.txt + conda pandoc) with apt install pandoc and pip install ., keeping up with the pyproject.toml migration in Migrate packaging from setup.py to pyproject.toml #82

  • Other general cosmetic changes also made

  • Document when stricter doc build options can be enforced in CI doc build

CozySocksAlways and others added 3 commits September 3, 2026 09:16
* Replaced depricated plt.cm.get_cmap api

* Switched to newer API for getting colormap

* Apply suggestions from code review

Co-authored-by: Michael Denker <m.denker@fz-juelich.de>

* Bumbed matplotlib min version to allign with api change

---------

Co-authored-by: Michael Denker <m.denker@fz-juelich.de>
* Swapped out setup.py with pyproject.toml

* Adding a architectural decision record file

* Splitup into multiple adrs

* upper limit on setuptooks for python 3.8 support; ADR changes

* remove newer licence field from pyproject.toml since older setuptools doesn't understand it

* Added statement to exclude adrs from packaging

* Reinstated licence classifier as per PR review
CozySocksAlways added a commit that referenced this pull request Sep 7, 2026
version alone

actions/checkout@v6.0, actions/setup-python@v6.2, and actions/cache@v5.0
don't exist as refs — GitHub Actions only tags major (vN) or full semver
(vN.N.N), never a two-part vN.N. This was failing every job in PR #83
with "unable to resolve action" errors.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PBNgnLD1qDqXsQsn15ivzk
@CozySocksAlways
CozySocksAlways marked this pull request as ready for review September 7, 2026 14:30

@kohlerca kohlerca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and updates in the CI workflow look good to me.

However, I identified that during the documentation build, there is a non-fatal failure in plot_patterns_hypergraph and plot_ue, which prevents the plots from showing in the documentation. I would expect those errors to fail one job in the CI.

This is somewhat independent from this refactoring PR, although we should have those errors flagged.

…ut np.stack with list comprehension in doc strings example
@CozySocksAlways

Copy link
Copy Markdown
Contributor Author

The changes and updates in the CI workflow look good to me.

However, I identified that during the documentation build, there is a non-fatal failure in plot_patterns_hypergraph and plot_ue, which prevents the plots from showing in the documentation. I would expect those errors to fail one job in the CI.

This is somewhat independent from this refactoring PR, although we should have those errors flagged.

Thanks for going through the logs to find those silent failures!
So I looked into them, one of them was an easy fix, I swapped out a numpy.stack with a list comprehension to avoid a shape mismatch in the doc strings example
The other one with holoviews will hopefully be fixed with the PR #77 .
I also would suggest once PR #77 or a later one to add stricter doc build check with the sphinx options in CI build. Something like make html SPHINXOPTS="-W --keep-going" should cause a doc build fail when such exceptions happen in the future.

@kohlerca

Copy link
Copy Markdown
Contributor

I also would suggest once PR #77 or a later one to add stricter doc build check with the sphinx options in CI build. Something like make html SPHINXOPTS="-W --keep-going" should cause a doc build fail when such exceptions happen in the future.

Looks like a good plan.

@CozySocksAlways
CozySocksAlways merged commit 7ef216e into master Sep 15, 2026
9 checks passed
@CozySocksAlways
CozySocksAlways deleted the fix/ci_matrix branch October 30, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants