Repository navigation
Fix resolution unit in Imagick ResolutionModifier - #1548
Merged
olivervogel merged 1 commit intoOct 5, 2026
Merged
olivervogel merged 1 commit into
olivervogel merged 1 commit into
Conversation
Member
|
Thanks. |
Member
|
Also fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setResolution()is documented as DPI, but the Imagick driver keeps whatver unit the image already had. ImageMagick reads a PNG's pHYs chunk as pixels per centimetre, sosetResolution(300, 300)on a PNG from disk saves a 762 DPI file. A PNG with no pHYs at all gets no unit either, and saves without any DPI. GD writes 300 for both.This sets the unit to pixels per inch along with the resolution. The new test reuses
300dpi.pngand fails ondevelopas it stands.crop()on Imagick has the same gap. The canvas it rebuilds gets the resolution but not the unit, so a cropped image saves with an "unknown" unit, even a JPEG that started out in inches.