Repository navigation
Tombstoning a stream frees its natural key (fisher#522) - #523
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jeremydmiller
added a commit
that referenced
this pull request
Nov 5, 2026
Conflict in EventAuxiliaryOperationsForSqlite.cs: main's #523 and this branch each added the natural-key delete to TombstoneStreamOperation, the same fix (same stream column, same conjoined tenant term, same set of tables). Kept main's as the one implementation. Also dropped this branch's EventGraph.QuotedNaturalKeyTableNames(), which nothing uses now; main's NaturalKeyDefinitions() is the one that stays. Directory.Packages.props / Directory.Build.props merged cleanly to main's: Fisher 1.28.0, JasperFx.* 2.100.0, Weasel.* 9.49.0. Kept this branch's smoke/aot-consumer pin of JasperFx.Events.SourceGenerator 2.100.0, since main still pins 2.98.0 there, behind its own Directory.Packages.props. Kept as they were: SupportsSessionTenantSwitching => true with the ForTenant override, SupportsHoldingAnAppendOpen => false with its reason, and the compliance_suite_inventory enrollment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
TombstoneStreamOperationnow deletes the stream's rows from everyfi_natural_key_*table (the lookup has no foreign key, so nothing else removed them). Under conjoined tenancy the delete is tenant-scoped, so other tenants keep their keys.Tests: two new facts in
natural_keys(single-tenant and conjoined) mirroring the two JasperFx 2.100 compliance facts; full Fisher.Tests green on net9.0 and net10.0. The 2.100 suite itself arrives with #521.🤖 Generated with Claude Code