Repository navigation
Run the unit test suites on a Windows runner in CI - #1146
Merged
Merged
Conversation
Linux CI cannot catch platform assumptions such as the '/'-only path check in AssemblyFinder (#1143). The new `windows` job runs the same test targets as the Linux `build` job through build.ps1, with the committed line endings kept on checkout. The CLI and AOT smoke tests stay Linux-only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
override_the_content_root used "/bin", which exists on Linux and macOS but resolves to a missing D:\bin\ on the Windows runner, where the host's PhysicalFileProvider throws DirectoryNotFoundException. Use a fresh temp directory instead. This was the only failure in the first Windows CI run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeremydmiller
marked this pull request as ready for review
November 8, 2026 17:22
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
windowsjob todotnet.yml. It runs onwindows-latestand executes the same test targets as the Linuxbuildjob, through./build.ps1:compile, test-core, test-codegen, test-codegen-fsharp, test-command-line, test-events, test-event-store, test-source-generators, test-aspire, test-microsoft-extensions-ai
Like the Linux job, every step runs even when an earlier one fails, so a single run shows every Windows-specific failure.
Why: #1143 was a Windows-only bug:
AssemblyFinderlooked for"/runtimes"with a forward slash. Linux CI can't catch that kind of path or platform assumption.Notes
core.autocrlfis set tofalsebefore checkout. Tests that compare generated code with committed fixtures then see the same bytes as on Linux. The aim is to test JasperFx on Windows, not git's line-ending conversion.smoke-test-aotand theaot-cligate (Run the JasperFx command line from a Native AOT binary; gate it in CI (#1141) #1142). They are about the command line and native publish, not platform paths.Opened as a draft: this is the first time these suites run on Windows, so the first run may turn up real Windows failures. Those will be fixed here or split out before this is marked ready.
First Windows run
Every suite passed except
test-command-line, which had one failure on both frameworks.override_the_content_rootused/binas the content root. That folder exists on Linux and macOS, but on Windows it resolves to a missingD:\bin\, and the host'sPhysicalFileProviderthrows. The test now uses a fresh temp directory. This was a test problem, not a library one.🤖 Generated with Claude Code