Repository navigation
feat(win32): 新增 AnchoredTouch 输入方式 #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ea82815
feat: add Win32InputMethod
SweetSmellFox b75a161
Merge pull request #1 from SweetSmellFox/fox
SweetSmellFox d5a5362
Merge branch 'MaaXYZ:main' into main
SweetSmellFox 6c70852
Merge branch 'MaaXYZ:main' into main
SweetSmellFox e652e8c
feat: support Win32 anchored touch input
SweetSmellFox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): AnchoredTouch 被分配到了第 10 位(
0x400),而现有输入方法通过第 8 位连续占用,导致第 9 位未被使用。原生控制器会原样接收此值,因此当该 ABI 值应为下一位时,新方法无法选择原生的 AnchoredTouch 实现。触发条件: 当调用方为 Win32 控制器选择
Win32InputMethod.AnchoredTouch时。建议修复: 使用
(1 << 9),除非原生 ABI 有意保留第 9 位;在这种情况下,应针对原生枚举记录并验证该保留位。Original comment in English
issue (bug_risk): AnchoredTouch is assigned bit 10 (
0x400) while the existing input methods occupy consecutive bits through bit 8, leaving bit 9 unused. The native controller receives this value unchanged, so the new method does not select the native AnchoredTouch implementation when that ABI value is the next bit.Triggers: When a caller selects
Win32InputMethod.AnchoredTouchfor a Win32 controller.Suggested fix: Use
(1 << 9)unless bit 9 is intentionally reserved by the native ABI, in which case document and verify that reservation against the native enum.