Repository navigation
Drop the glue dependency in favor of base R - #265
Merged
Merged
Conversation
Replace the four `glue::glue_data()` call sites with equivalent base R:
- The three footnote templates in `gt_ae_specific()`, `tlf_ae_specific()`,
and `tlf_ae_specific_subgroup()` only substitute `{meddra_version}`, so a
fixed `gsub()` over the footnote vector suffices.
- The observation-section labels in `prepare_ae_specific()` use `sprintf()`
with the parameter mapping's `term1`/`term2`.
Remove `glue` from Imports. Output is unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
yihui
marked this pull request as ready for review
November 5, 2026 15:25
LittleBeannie
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
glueimport, replacing its fourglue::glue_data()call sites with equivalent base R. No behavior change; the affected tests pass.R/gt_ae_specific.Rfootnotesgsub("{meddra_version}", ...)R/tlf_ae_specific.Rfootnotesgsub("{meddra_version}", ...)R/tlf_ae_specific_subgroup.Rfootnotesgsub("{meddra_version}", ...)R/prepare_ae_specific.Robs labelssprintf()over the mapping'sterm1/term2The footnote templates only ever substitute a single
{meddra_version}placeholder, so a fixedgsub()over the footnote vector is exact and vectorized. The observation-section labels evaluatetolower(term1)/tolower(term2), handled bysprintf().Verification
testthat::test_dir(..., filter="specific")-> 62 pass;filter="gt_ae|subgroup"-> 15 pass. Package loads cleanly.🤖 Generated with Claude Code