Repository navigation
Conversation
Rewrite react_ae_listing() to render the interactive AE listing with the lightweight lt package instead of reactable. The function keeps its name and signature but now returns an lt_tbl object built with lt_interactive() (per-column filters, global search, pagination, resizable columns) plus striped/hover styling via lt_css() and a container width via lt_wrap(). In patient_folding mode the patient-ID column becomes a dropdown of full IDs (exact match, no free-text box), global search is off, and the table starts empty via a control-character sentinel until a participant is selected. - DESCRIPTION: drop reactable from Suggests, add lt to Imports, add Remotes: yihui/lt (lt is not on CRAN). - Rename the vignette ae-listing-reactable.Rmd -> ae-listing.Rmd and update _pkgdown.yml; fix an AEREL typo in the metadata definition. - Rewrite the tests for the lt_tbl output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react_ae_listing()rendered the interactive AE listing withreactable. This migrates it to the lightweightltpackage, mirroring forestly's reactable→lt migration (Merck/forestly#168, #169).The exported function keeps its name and signature (
react_ae_listing(outdata, default_page_size, searchable, striped, highlight, patient_folding, width)). The one API change is the return type: it now returns anlt_tblobject (which prints / knits to an interactive HTML table) instead of areactablehtmlwidget.What changed
R/react_ae_listing.Rlt::lt()(raw column names as data keys; display labels applied vialt_label()), thenlt::lt_interactive():filter = TRUE), globalsearch, pagination (requesteddefault_page_sizefirst, then 10/25/50/100), resizable columns."select"dropdown of full IDs (box = FALSE, exact match). Seeded with a control-characterselectedsentinel absent from the data, so the table starts empty until a participant is picked.striped/highlightare scoped CSS rules vialt_css()(lt has no zebra/hover default).widthsizes the container vialt_wrap(style = "width:...;overflow-x:auto").Packaging / docs
DESCRIPTION: dropreactablefrom Suggests, addltto Imports, addRemotes: yihui/lt(lt is not on CRAN).ae-listing-reactable.Rmd→ae-listing.Rmd(the old name referenced reactable) and update_pkgdown.yml; also fix anAREL→AERELtypo in the vignette'sdefine_parameter()subset.man/react_ae_listing.Rd.lt_tbloutput.Differences from the reactable version
lt_tbl, not areactablehtmlwidget."select"filter) rather than a free-text exact-match box; privacy "start empty" behavior is preserved.minWidth = 120and thebordered/compact/wrapcosmetic flags have no direct lt equivalent and are dropped;striped/highlightare reproduced via CSS.Test plan
devtools::load_all()+testthat::test_dir(filter = "react_ae_listing")— all pass.format()); the folding spec serializes the select filter + sentinel, striping and width rules are present.🤖 Generated with Claude Code