Repository navigation
Remove Fabric Permissions API - #48
Merged
Merged
Conversation
and hasn't for a while
Replace with the one from Fabric API
Ampflower
requested changes
Sep 19, 2026
Ampflower
left a comment
Ampflower
left a comment
Member
There was a problem hiding this comment.
Noticed this; minimum level should be 2, not 1.
| public static boolean modify(ServerPlayer player, Identifier shardId, Shard shard) { | ||
| MinecraftServer server = player.level().getServer(); | ||
|
|
||
| boolean success = server.isSingleplayer() || Permissions.check(player, ScatteredShardsAPI.MODIFY_SHARD_PERMISSION, PermissionLevel.GAMEMASTERS); |
Member
There was a problem hiding this comment.
This doesn't appear to be equivalent.
Member
There was a problem hiding this comment.
On your end it is not, you have moderators GitHub's 'additions' gutter is annoyingly inconsistent.
I blame git
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use FAPI's Permission API