Repository navigation
Remove deleteAll command - #49
Merged
Merged
Conversation
Ampflower
approved these changes
Sep 20, 2026
Ampflower
left a comment
Ampflower
left a comment
Member
There was a problem hiding this comment.
Looks good; just one misc thing I'm not considering a blocker for this.
|
|
||
| public static boolean hasShiftDown() { | ||
| return InputConstants.isKeyDown(340) || InputConstants.isKeyDown(344); | ||
| return InputConstants.isKeyDown(InputConstants.KEY_LSHIFT) || InputConstants.isKeyDown(InputConstants.KEY_RSHIFT); |
Member
There was a problem hiding this comment.
Isn't there a function within Keyboard for this?
falkreon
reviewed
Sep 20, 2026
| realLibrary.shardTypes().forEach((fakeShardTypes::put)); | ||
| fakeLibrary.shardDisplaySettings().copyFrom(realLibrary.shardDisplaySettings()); | ||
| context.getSource().getClient().schedule(() -> context.getSource().getClient().setScreenAndShow(new ShardTabletGuiDescription.Screen(shardCollection, fakeLibrary))); | ||
| setScreen(context, () -> new ShardTabletGuiDescription.Screen(shardCollection, fakeLibrary)); |
Collaborator
There was a problem hiding this comment.
Hopefully this issue is gone; we did run into a race condition where the game wouldn't laterally move from a screen to another screen, you had to effectively do it on a different tick.
Collaborator
There was a problem hiding this comment.
Edit- never mind, I see, you factored it into a function. Carry on!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"team members have expressed discomfort having it around"
"just delete the files yourself"
Would close #42
Also adds some misc cleanup