Repository navigation
CI follow-up: cache source-built wheels and extensions, bump CI containers, trim slow GPU tests #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevalmorabia97
wants to merge
28
commits into
main
Choose a base branch
from
kmorabia/ci-gpu-followup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+420
−175
Open
CI follow-up: cache source-built wheels and extensions, bump CI containers, trim slow GPU tests #2836
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b7b7657
Worker pool: report a failed rank before its teardown; move the helpe…
kevalmorabia97 e5d149e
CI: cache source-built wheels in the gpu job and bump the CI containers
kevalmorabia97 4aedd5f
Remove the duplicate gpu_megatron copy of the CUDA extension tests
kevalmorabia97 95b4913
gpu job: save the wheel cache even when the tests fail or time out
kevalmorabia97 7e8cfd1
CI: save the CUDA extension cache even when the job fails or times out
kevalmorabia97 8c5fadc
EAGLE: compile _eagle_forward without CUDA graphs
kevalmorabia97 613e40e
gpu job: build mamba_ssm and causal-conv1d as C++20
kevalmorabia97 ae6f163
NVFP4: convert cutlass-swizzled block scales in ModelOpt instead of i…
kevalmorabia97 e0dafde
Keep vLLM at v0.30.0: v0.31.0 breaks the vLLM plugin
kevalmorabia97 27235c7
Address review: wheelhouse path, complete-only cache save, wheel look…
kevalmorabia97 db68967
trtllm examples: install fla-core for TensorRT-LLM rc29
kevalmorabia97 4ffb17e
Pin TensorRT-LLM to rc23; build the conv3d implicit-GEMM extension wi…
kevalmorabia97 a04bd58
persistent_materialization: skip FSDP2 unshard only for the materiali…
kevalmorabia97 878ffc5
noxfile: drop the stale cppimport note
kevalmorabia97 6253454
Merge remote-tracking branch 'origin/main' into kmorabia/ci-gpu-followup
kevalmorabia97 50615b3
Address review: retire a pool after any failed job; restore nested FS…
kevalmorabia97 635c761
NVFP4: return a contiguous scale from cutlass_fp4_scale_to_modelopt_f…
kevalmorabia97 f181890
Keep TensorRT-LLM at rc20
kevalmorabia97 9d3d714
gpu_megatron: destroy each test's process groups in the worker teardown
kevalmorabia97 9d9ab38
Merge remote-tracking branch 'origin/main' into kmorabia/ci-gpu-followup
kevalmorabia97 7fc0595
Use a fixed tile config for the NVFP4 FP8 sweep kernel; drop unneeded…
kevalmorabia97 528c39e
Test the FSDP2 unshard/reshard override with a shared param group and…
kevalmorabia97 1203fcd
Key the torch-extension cache on the C++/CUDA sources only
kevalmorabia97 0ef079a
Drop the vLLM v0.20.0 gpu_vllm job
kevalmorabia97 f222d46
Only skip FSDP unshard/reshard when the materialized layer is FSDP-wr…
kevalmorabia97 f086740
Raise gpu_vllm timeout to 20 min
kevalmorabia97 996f48e
Run only 3 puzzletron models in CI and raise test_mamba_search_space …
kevalmorabia97 f1311ea
Key the extension cache per job and skip saving an empty one
kevalmorabia97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: Save extensions | ||
| description: Save the JIT-compiled extensions restored by ./.github/actions/cache-extensions. Run it with `always()` so a failing or timed-out job still | ||
| populates the cache (actions/cache itself only saves when the job succeeds). | ||
|
|
||
| inputs: | ||
| cache-key: | ||
| description: The `cache-key` output of ./.github/actions/cache-extensions. | ||
| required: true | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| # A job cancelled before building anything must not claim the key with an empty cache: | ||
| # later runs would restore it as an exact hit and never save again. | ||
| - id: built | ||
| shell: bash | ||
| run: find /root/.cache/torch_extensions -name '*.so' 2>/dev/null | grep -q . && echo "any=true" >> "$GITHUB_OUTPUT" || true | ||
| - if: steps.built.outputs.any == 'true' | ||
| uses: actions/cache/save@v6 | ||
| with: | ||
| path: /root/.cache/torch_extensions | ||
| key: ${{ inputs.cache-key }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.