Repository navigation
fix: MQTT v2 callback API and disconnect leak (#15, #16) - #32
Merged
weslleyspereira merged 5 commits intoSep 15, 2026
Merged
Conversation
…bRockies#16) Issue NatLabRockies#15: mqtt_publisher used the deprecated paho-mqtt v1 callback API while pyproject requires paho-mqtt>=2.0.0, producing a DeprecationWarning and future breakage. - Construct mqtt.Client with callback_api_version=VERSION2 - Update _on_connect/_on_disconnect/_on_publish to the v2 signatures, handling ReasonCode objects (is_failure/value) Issue NatLabRockies#16: the MQTT publisher's network-loop thread was never stopped and no DISCONNECT was sent on teardown (resource leak). - Add Tracker.disconnect_mqtt() (idempotent) and a stop() override that disconnects in a finally block - Route Tracker.__exit__ and track_until_forced_exit through the cleanup - Add matching cleanup to TrackerArray for all child trackers Update the test FakeMQTTModule to the v2 API and add regression tests covering both issues.
The merge of main into this branch replaced BaseTracker._read_and_sleep() with an inlined scheduler (_sleep_until_next_tick), and a branch-only commit changed Tracker.start/stop default freq_write from 0 to -1 (= self.freq_write). Both changes are correct but broke the MQTT tests added earlier, which were written against the old API/semantics. - Re-point interrupt injection from the removed _read_and_sleep seam to the new _sleep_until_next_tick scheduler in the tracker and CLI tests. - Update CLI assertions to expect track_until_forced_exit(disconnect_mqtt =False), matching the CLI's cleanup-ownership flow. - Account for the new read-loop structure (one loop read + one final read) in test_cli_final_batch_before_disconnect read counts, batch sample counts, and written-row counts, including partial writes when the last array reader fails. - Reframe test_write_after_stop_is_local_only around the real invariant: stop() flushes the final batch, and a subsequent write() must not publish again or recreate a publisher. Full suite: 225 passed, 5 skipped.
weslleyspereira
approved these changes
Sep 15, 2026
weslleyspereira
left a comment
Collaborator
There was a problem hiding this comment.
Great work! Thanks
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #15: mqtt_publisher used the deprecated paho-mqtt v1 callback API while pyproject requires paho-mqtt>=2.0.0, producing a DeprecationWarning and future breakage.
Issue #16: the MQTT publisher's network-loop thread was never stopped and no DISCONNECT was sent on teardown (resource leak).
Update the test FakeMQTTModule to the v2 API and add regression tests covering both issues.