Repository navigation
Keep the PostgreSQL 17 copy through an interrupted restore, and harden the 44.0 regenerations - #653
Merged
Merged
Conversation
…n the 44.0 regenerations - compose.yaml: putting the copy back leaves a mark in the backup volume, so a restore stopped half-way is started again, instead of the partial data being taken for the 17 data and the copy deleted. The rehearsal script gains INTERRUPT_RESTORE=1. - The segment recompilation stores a query only while the segment still holds the tree and arguments it was compiled from; a segment saved meanwhile is read again and recompiled from what was saved. - The trigger regeneration fails the run on a lock timeout, a deadlock or a serialization failure, instead of leaving a valid automation on its old body; the migration runs again at the next start. - Dockerfile: the console build gets a 4 GB Node heap, which a host under 16 GB of memory does not give it by default.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #653 +/- ##
==========================================
- Coverage 90.46% 90.44% -0.02%
==========================================
Files 392 392
Lines 76454 76497 +43
==========================================
+ Hits 69162 69189 +27
- Misses 4736 4745 +9
- Partials 2556 2563 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while rehearsing the 44.0 upgrade (43.0 compose on PostgreSQL 17, demo data and live automations, then the 44.0 compose and image).
scripts/pg-upgrade-rehearsal.shgainsINTERRUPT_RESTORE=1(withINTERRUPT=1): it passes with this change and fails without it.cmd/regen-json-filters): a query is stored only while the segment still holds the tree and arguments it was compiled from; a segment saved meanwhile is read again and recompiled from what was saved. Unit tests, and an integration test that saves the segment between the read and the write; it fails with the previous guard.statement_timeoutcancellation still skips the automation, since it would repeat at every start.node:22-alpinedefaults to about 2 GB and the build ran out of memory.No CHANGELOG entry: all of it changes 44.0 code that has not been released.