Repository navigation
Trace Generation Dialog: Retain trace input focus on enter - #1342
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
A skipped edit after an on-disk reload can leave the input displaying an uncommitted value that subsequent Enter or blur events cannot retry.
1 open issue
What changed in this PR
This PR addresses the Enter-key editing behavior in #1292, keeping focus and the caret in Trace Generation text fields while the host processes edits.
Changes:
- Commit on Enter without blurring, while leaving composition events untouched.
- Track text-edit completion across host updates to preserve active drafts and selection.
- Add renderer and provider tests for focus retention, overlapping edits, and completion handling.
| File | Description |
|---|---|
src/webviews/trace-configuration/src/trace-configuration.ts |
Preserves active text edits and focus across host renders. |
src/webviews/trace-configuration/src/trace-configuration.test.ts |
Tests Enter behavior, draft retention, and focus boundaries. |
src/views/trace-configuration/trace-configuration-webview-provider.ts |
Sends completion IDs after handling text edits. |
src/views/trace-configuration/trace-configuration-webview-provider.test.ts |
Tests completion timing, failures, and disposal. |
src/views/trace-configuration/trace-configuration-protocol.ts |
Adds optional edit and completion IDs to messages. |
Review effort: Balanced
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|


Fixes
Changes
Enterkey press to commit pending edit but stop propagation to keep focus/cursor in place for further editingScreenshots
Checklist