Skip to content

Trace Generation Dialog: Add clear button for multi-select dropdown controls - #1344

Merged
JonatanAntoni merged 2 commits into
mainfrom
clear-multiselect
Nov 2, 2026
Merged

JonatanAntoni merged 2 commits into
mainfrom
clear-multiselect

Conversation

@JonatanAntoni

@JonatanAntoni JonatanAntoni commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Fixes

Changes

  • Add explicit clear all button behind the multi-selection dropdown controls

Screenshots

Screenshot 2026-11-02 at 16 23 53

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The review reports no active issues with the multi-select clear-all changes.

No open issues 🎉

What changed in this PR

Adds clear-all buttons to multi-select controls in the Trace Generation dialog, addressing the selection-reset usability request in #1292.

Changes:

  • Clears all selections in one action, returns focus to the dropdown, and disables clearing when nothing is selected.
  • Updates control layout and focus styling while preserving dropdown state across host refreshes.
  • Adds tests for clearing interactions, host synchronization, and saving cleared selections without removing unrelated configuration.
File Description
src/​webviews/​trace-configuration/​src/​trace-configuration.ts Adds clear buttons and updates selection, focus, and interaction handling.
src/​webviews/​trace-configuration/​src/​trace-configuration.test.ts Extends DOM fixtures and tests clear-button behavior.
src/​webviews/​trace-configuration/​src/​trace-configuration.css Styles clear buttons, focus indicators, and truncated selection labels.
src/​views/​trace-configuration/​trace-configuration-model.test.ts Tests persistence of cleared event counters, ITM channels, and privilege ranges.

Review effort: Balanced

@qltysh

qltysh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@arneschmid arneschmid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonatanAntoni
JonatanAntoni merged commit 83b12dd into main Nov 2, 2026
16 checks passed
@JonatanAntoni
JonatanAntoni deleted the clear-multiselect branch November 2, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants