Skip to content

fix(builder): size the compiler's terminal - #230

Open
0xisk wants to merge 1 commit into
mainfrom
fix/builder-pty-size
Open

0xisk wants to merge 1 commit into
mainfrom
fix/builder-pty-size

Conversation

@0xisk

@0xisk 0xisk commented Nov 18, 2026

Copy link
Copy Markdown
Member

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

script opens its PTY 0x0 when stdin is not a terminal, and compactc draws no progress row below the last line. circuit-info.json then misses circuits: 24 of 25 for compact-contracts' MockNonFungibleToken, on compactc 0.36.0 and 0.36.1.

Verified with real compilers: the fixed bin writes 25 of 25 on 0.36.0 and 0.36.1, and the fungible-token example keeps its five values on 0.35.0, 0.36.0 and 0.36.1.

Not visible in the diff:

  • The macOS branch changed the same way and was not run on a Mac.
  • 500 by 200 is the size compact-lint's PTY already uses.
  • A failed compile prints script's header line, which now shows the stty prefix.

PR Checklist

  • I have read the Contributing Guide
  • I have added tests that prove my fix is effective or that my feature works
  • I have added documentation of new methods and any new behavior or changes to existing behavior
  • CI Workflows Are Passing

`script` opens its PTY 0x0 when stdin is not a terminal, and compactc
draws no progress row below the last line. A contract with 25 circuits
lost one from `circuit-info.json`. The command now sets the PTY to 500
rows by 200 columns before the compiler starts.
@0xisk
0xisk requested review from a team as code owners November 18, 2026 09:55
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7aeca728-61de-41e5-a55f-fd3519c3ba63
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants