Repository navigation
Hardhat 3 migration #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amxx
wants to merge
55
commits into
master
Choose a base branch
from
hardhat3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hardhat 3 migration #283
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
a79f304
migration to hardhat 3: dependencies and tests
Amxx 34024d9
update dependency
Amxx a022e26
update imports
Amxx 8bd17a1
reorder imports
Amxx 774104b
fix sol linting
Amxx 3955d22
fix enumerable set & map (missing removeAt)
Amxx d7b34cc
Bound ERC7786OpenBridge recipient return data copy
Amxx 97f1049
Drop unused _wormholeChainId from WormholeGatewayAdapter
Amxx dbab7a9
Merge remote-tracking branch 'origin/master' into hardhat3
Amxx 0714276
Deduplicate ERC7786OpenBridge return bomb test
Amxx 09c9167
Restore lib/ exclusion in the js linting scripts
Amxx 26d1c4b
Apply suggestion from @Amxx
Amxx 4ad1318
Fix inheritance ordering
james-toussaint 1f7b30d
update scripts
Amxx 3b5b37e
fix inheritance ordering script
Amxx f264fe6
Derive inheritance-ordering check scope from package.json files
Amxx ce2ac7c
dependency update
Amxx 7285741
Merge branch 'hardhat3' into fix/inheritance-ordering
Amxx 0d1308f
Fix inheritance ordering (#286)
james-toussaint 09efe3d
update .github actions and workflows
Amxx 88eac67
checkout submodules in the lint and slither jobs
Amxx ef4b8ff
add missing workflows
Amxx 37ddfe1
fix halmos
Amxx 67fbe9b
remove unused imports
Amxx 94455b5
link missing script
Amxx 5247491
disable fv workflows (keep files as .yml.disabled)
Amxx f53f4c6
fix forge lint unused-import
Amxx 9732ad5
fix gas-compare: pass --root to list-dependencies
Amxx 452e9cc
docs: port the documentation pipeline to Hardhat 3 (#288)
Amxx 387bc9e
Merge remote-tracking branch 'origin/master' into hardhat3
Amxx a33d9fa
Update OpenZeppelin Contracts submodules and make ERC7540 deposit/min…
Amxx 8600cc2
Transpile upgradeable variant with the hardhat-transpiler plugin
Amxx 778353b
Minimize pragmas and mark files copied from OpenZeppelin Contracts
Amxx 7ebbf0e
Remove disabled formal verification workflows
Amxx e93170a
Mark gas-compare action as a copy of the OpenZeppelin Contracts one
Amxx 91d9849
Use the OpenZeppelin Contracts setup action
Amxx 83ba966
Update lib/@openzeppelin-contracts to fix setup action quotes
Amxx b90ba49
Align checks workflow with OpenZeppelin Contracts
Amxx 5548062
Restore the submodules checkout in the docs workflow
Amxx 35ad4e6
Fix the pragma of mocks
Amxx e4cb365
Mark docs files copied from OpenZeppelin Contracts
Amxx adc215c
Mark docs helpers as a copy of the OpenZeppelin Contracts one
Amxx 290299c
Update package.json
Amxx bbe5717
Fix CI: regenerate package-lock.json and lint the ERC-7540 Foundry tests
Amxx a96400b
Use the OpenZeppelin Contracts codecov config and pre-commit hook
Amxx 25c4c39
ERC4626Fees: silence slither locked-ether false positive
Amxx ac56bdd
Allow manually triggering the upgradeable transpilation
Amxx db53359
Update the OpenZeppelin Contracts submodule
Amxx 6c11428
Update the OpenZeppelin Contracts submodule
Amxx 45a5f94
Track OpenZeppelin Contracts master now that #6872 is merged
Amxx 0b30583
Symlink scripts that are exact copies of the OpenZeppelin Contracts ones
Amxx 3bc09b6
Publish the docs from master again
Amxx d6596ab
Resolve @openzeppelin/contracts through the submodule for Foundry
Amxx 6f0c765
Destructure connection in AxelarHelper and WormholeHelper
james-toussaint 0537d30
Remove unused imports from the mocks import file
Amxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,94 @@ | ||
| # This file is an exact copy of lib/@openzeppelin-contracts/.github/actions/setup/action.yml. | ||
|
|
||
| name: Setup | ||
| description: Common environment setup | ||
| inputs: | ||
| node: | ||
| description: Whether to set up node | ||
| required: false | ||
| default: 'on' # 'off' | 'on' | <specific version> | ||
| foundry: | ||
| description: Whether to set up Foundry | ||
| required: false | ||
| default: 'off' # 'off' | 'on' | <specific version> | ||
| python: | ||
| description: Whether to set up Python | ||
| required: false | ||
| default: 'off' # 'off' | 'on' | <specific version> | ||
| python-requirements: | ||
| description: Path to Python requirements file (if python is true) | ||
| required: false | ||
| default: 'requirements.txt' | ||
| cache: | ||
| description: How this job may use the shared dependency cache | ||
| required: false | ||
| # 'restore' reads the cache but never writes it back. A job that runs untrusted code MUST use it: | ||
| # the cache scope is keyed on the branch, so a write from such a job lands where every other | ||
| # workflow reads from. | ||
| default: 'on' # 'off' | 'restore' | 'on' | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - uses: actions/setup-node@v4 | ||
| - name: 'Determine versions to install' | ||
| id: versions | ||
| shell: bash | ||
| run: | | ||
| ( | ||
| [[ "${{ inputs.node }}" = "on" ]] \ | ||
| && echo "node=$NODE_DEFAULT_VERSION" \ | ||
| || echo "node=${{ inputs.node }}" | ||
| [[ "${{ inputs.foundry }}" = "on" ]] \ | ||
| && echo "foundry=$FOUNDRY_DEFAULT_VERSION" \ | ||
| || echo "foundry=${{ inputs.foundry }}" | ||
| [[ "${{ inputs.python }}" = "on" ]] \ | ||
| && echo "python=$PYTHON_DEFAULT_VERSION" \ | ||
| || echo "python=${{ inputs.python }}" | ||
| ) > $GITHUB_OUTPUT | ||
| env: | ||
| NODE_DEFAULT_VERSION: '24.x' | ||
| FOUNDRY_DEFAULT_VERSION: 'stable' | ||
| PYTHON_DEFAULT_VERSION: '3.13' | ||
| # Node & npm setup | ||
| - name: Install Node (${{ steps.versions.outputs.node }}) | ||
| if: inputs.node != 'off' | ||
| uses: actions/setup-node@v7 | ||
| with: | ||
| node-version: 22.x | ||
| - uses: actions/cache@v4 | ||
| node-version: ${{ steps.versions.outputs.node }} | ||
| - name: Try fetch node modules from cache | ||
| id: cache | ||
| if: inputs.node != 'off' && inputs.cache == 'on' | ||
| uses: actions/cache@v6 | ||
| with: | ||
| path: '**/node_modules' | ||
| key: npm-${{ steps.versions.outputs.node }}-${{ hashFiles('**/package-lock.json') }} | ||
| - name: Try fetch node modules from cache (read only) | ||
| id: cache-restore | ||
| if: inputs.node != 'off' && inputs.cache == 'restore' | ||
| uses: actions/cache/restore@v6 | ||
| with: | ||
| path: '**/node_modules' | ||
| key: npm-v3-${{ hashFiles('**/package-lock.json') }} | ||
| key: npm-${{ steps.versions.outputs.node }}-${{ hashFiles('**/package-lock.json') }} | ||
| - name: Install dependencies | ||
| run: npm ci | ||
| if: inputs.node != 'off' && steps.cache.outputs.cache-hit != 'true' && steps.cache-restore.outputs.cache-hit != 'true' | ||
| shell: bash | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| - name: Install Foundry | ||
| run: npm ci | ||
| # Foundry setup | ||
| - name: Install Foundry (${{ steps.versions.outputs.foundry }}) | ||
| if: inputs.foundry != 'off' | ||
| uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| version: stable | ||
| version: ${{ steps.versions.outputs.foundry }} | ||
| # Python setup | ||
| - name: Install python (${{ steps.versions.outputs.python }}) | ||
| if: inputs.python != 'off' | ||
| uses: actions/setup-python@v7 | ||
| with: | ||
| python-version: ${{ steps.versions.outputs.python }} | ||
| # `setup-python` has no read-only mode, so any caller that cannot write the cache goes without | ||
| cache: ${{ inputs.cache == 'on' && 'pip' || '' }} | ||
| cache-dependency-path: ${{ inputs.python-requirements }} | ||
| - name: Install python packages | ||
| if: inputs.python != 'off' | ||
| shell: bash | ||
| run: pip install -r ${{ inputs.python-requirements }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # This file is an exact copy of lib/@openzeppelin-contracts/.github/workflows/actionlint.yml. | ||
|
|
||
| name: lint workflows | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - '.github/**/*.ya?ml' | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - name: Add problem matchers | ||
| run: | | ||
| # https://github.com/rhysd/actionlint/blob/3a2f2c7/docs/usage.md#problem-matchers | ||
| curl -LO https://raw.githubusercontent.com/rhysd/actionlint/main/.github/actionlint-matcher.json | ||
| echo "::add-matcher::actionlint-matcher.json" | ||
| - uses: docker://rhysd/actionlint:latest | ||
|
Comment on lines
+12
to
+20
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.